This is an archive of the discontinued LLVM Phabricator instance.

Differential D34004

Add BinaryFormat to library list for lldCore
ClosedPublic

Authored by sbc100 on Jun 7 2017, 10:58 AM.

Download Raw Diff

Details

Reviewers

Commits

rGc1e7a0dde551: Add BinaryFormat to lld libraries
rLLD304932: Add BinaryFormat to lld libraries
rL304932: Add BinaryFormat to lld libraries

Summary

Without this, when building with shared BUILD_SHARED_LIBS=ON
I get the following error:

lib/Core/Reader.cpp:40: error: undefined reference to
'llvm::identify_magic(llvm::StringRef)'

Diff Detail

Build Status

Buildable 7070
Build 7070: arc lint + arc unit

Event Timeline

sbc100 created this revision.Jun 7 2017, 10:58 AM

Harbormaster completed remote builds in B7070: Diff 101782.Jun 7 2017, 10:58 AM

Herald added a subscriber: mgorny. · View Herald TranscriptJun 7 2017, 10:58 AM

sbc100 added a reviewer: zturner.Jun 7 2017, 10:59 AM

sort

add to other libs too

Harbormaster completed remote builds in B7072: Diff 101784.Jun 7 2017, 11:04 AM

Herald added a subscriber: emaste. · View Herald TranscriptJun 7 2017, 11:04 AM

I'm not sure why this didn't break any of the LLD bots. Is it because they don't build with BUILD_SHARED_LIBS perhaps?

Closed by commit rL304932: Add BinaryFormat to lld libraries (authored by sbc). · Explain WhyJun 7 2017, 11:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

Core/

3 lines

Diff 101782

lib/Core/CMakeLists.txt

	Show All 14 Lines		add_lld_library(lldCore
	Writer.cpp			Writer.cpp

	ADDITIONAL_HEADER_DIRS			ADDITIONAL_HEADER_DIRS
	${LLD_INCLUDE_DIR}/lld/Core			${LLD_INCLUDE_DIR}/lld/Core

	LINK_COMPONENTS			LINK_COMPONENTS
	MC			MC
	Support			Support
				BinaryFormat

	LINK_LIBS			LINK_LIBS
	${LLVM_PTHREAD_LIB}			${LLVM_PTHREAD_LIB}

	DEPENDS			DEPENDS
	${tablegen_deps}			${tablegen_deps}
	)			)