This is an archive of the discontinued LLVM Phabricator instance.

Object: Add version and producer fields to the irsymtab header. NFCI.
ClosedPublic

Authored by pcc on Jun 6 2017, 5:58 PM.

Event Timeline

pcc created this revision.Jun 6 2017, 5:58 PM
tejohnson added inline comments.Jun 26 2017, 7:31 PM
llvm/include/llvm/Object/IRSymtab.h
137

Thinking it would be good to print these when dumping the symtab. That would help on one of the tests added on D33974 (I'll note it there).

pcc added inline comments.Jun 26 2017, 7:58 PM
llvm/include/llvm/Object/IRSymtab.h
137

Yes, maybe. It would mean that dump-symtab would have to have its own copy of the code that reads the header because right now it always uses (via a few layers of indirection) irsymtab::readBitcode which will always upgrade mismatching versions. I could add that in D33974 I suppose.

pcc marked an inline comment as done.Jun 27 2017, 3:54 PM
pcc added inline comments.
llvm/include/llvm/Object/IRSymtab.h
137

Done in the version of D33974 that I just uploaded.

This revision is now accepted and ready to land.Jun 27 2017, 4:15 PM
This revision was automatically updated to reflect the committed changes.