This is an archive of the discontinued LLVM Phabricator instance.

Remove `inline` keyword from inline `classof` methods
ClosedPublic

Authored by sbc100 on Jun 5 2017, 12:07 PM.

Details

Summary

The style guide states that the explicit inline
should not be used with inline methods.
classof is very common line method with a fair amount
on inconsistency:

$ git grep classof ./include | grep inline | wc -l
230
$ git grep classof ./include | grep -v inline | wc -l
257

I chose to target this method rather the larger change
this this method is often cargo-culted since its needed
in many classes. I considered doing the larger change
and removing all occurrences but that would be a much
larger change.

Event Timeline

sbc100 created this revision.Jun 5 2017, 12:07 PM

ping. This is a mechanical change so should be an easy review.

This revision is now accepted and ready to land.Jun 29 2017, 11:35 AM
This revision was automatically updated to reflect the committed changes.