This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Remove unused methods from MCWasmObjectTargetWriter
ClosedPublic

Authored by sbc100 on Jun 5 2017, 11:53 AM.

Details

Summary

These methods looks like they were originally came from MCELFObjectTargetWriter
but they are never called by the WasmObjectWriter.

Remove these methods meant the declaration of WasmRelocationEntry could
also move into the cpp file.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Jun 5 2017, 11:53 AM
sbc100 edited the summary of this revision. (Show Details)Jun 5 2017, 11:55 AM
sbc100 added a reviewer: sunfish.
sbc100 updated this revision to Diff 101491.Jun 5 2017, 5:40 PM
  • Merge remote-tracking branch 'origin/master' into remove_used_methods
  • move relocation entry decl
sbc100 updated this revision to Diff 101492.Jun 5 2017, 5:41 PM

revert move

sbc100 updated this revision to Diff 101493.Jun 5 2017, 5:42 PM
  • move relocation entry decl
sbc100 edited the summary of this revision. (Show Details)Jun 5 2017, 5:43 PM
sbc100 added a reviewer: jgravelle-google.
jgravelle-google accepted this revision.Jun 6 2017, 9:32 AM
This revision is now accepted and ready to land.Jun 6 2017, 9:32 AM
This revision was automatically updated to reflect the committed changes.