Page MenuHomePhabricator

[clang-tidy] misc-static-assert shouldn't flag assert(!"msg")
ClosedPublic

Authored by fgross on Jun 2 2017, 6:20 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

fgross created this revision.Jun 2 2017, 6:20 AM
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a project: Restricted Project.

While not directly related to this Differential, i wonder if it would make sense to also not warn on calls to (especially non-member) functions marked with __attribute__((const)), maybe __attribute__((pure)) too.
At least i'm not sure what side-effects such calls may have..

alexfh accepted this revision.Jun 2 2017, 12:37 PM

LG. Thank you!

This revision is now accepted and ready to land.Jun 2 2017, 12:37 PM
This revision was automatically updated to reflect the committed changes.