This is an archive of the discontinued LLVM Phabricator instance.

Differential D33808

[AMDGPU] V_DIV_FIXUP_F16 is not a commutable operation
ClosedPublic

Authored by rampitec on Jun 1 2017, 3:46 PM.

Details

Reviewers
arsenm
kzhuravl
Commits
rGca5d2efe5a69: [AMDGPU] V_DIV_FIXUP_F16 is not a commutable operation
rL304619: [AMDGPU] V_DIV_FIXUP_F16 is not a commutable operation

Diff Detail

Repository
rL LLVM

Event Timeline

rampitec created this revision.Jun 1 2017, 3:46 PM
Herald added subscribers: t-tye, tpr, dstuttard and 3 others. · View Herald TranscriptJun 1 2017, 3:46 PM
arsenm accepted this revision.Jun 2 2017, 1:31 PM

LGTM

This revision is now accepted and ready to land.Jun 2 2017, 1:31 PM
Closed by commit rL304619: [AMDGPU] V_DIV_FIXUP_F16 is not a commutable operation (authored by rampitec). · Explain WhyJun 2 2017, 5:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Target/
AMDGPU/
3 lines

Diff 101297

llvm/trunk/lib/Target/AMDGPU/VOP3Instructions.td

Show First 20 Lines • Show All 239 Lines • ▼ Show 20 Lines
def V_MAD_I64_I32 : VOP3Inst <"v_mad_i64_i32", VOP3b_I64_I1_I32_I32_I64>; def V_MAD_I64_I32 : VOP3Inst <"v_mad_i64_i32", VOP3b_I64_I1_I32_I32_I64>;
} // End isCommutable = 1 } // End isCommutable = 1
} // End SubtargetPredicate = isCIVI } // End SubtargetPredicate = isCIVI
let SubtargetPredicate = Has16BitInsts in { let SubtargetPredicate = Has16BitInsts in {
def V_DIV_FIXUP_F16 : VOP3Inst <"v_div_fixup_f16", VOP3_Profile<VOP_F16_F16_F16_F16>, AMDGPUdiv_fixup>;
let isCommutable = 1 in { let isCommutable = 1 in {
def V_DIV_FIXUP_F16 : VOP3Inst <"v_div_fixup_f16", VOP3_Profile<VOP_F16_F16_F16_F16>, AMDGPUdiv_fixup>;
def V_FMA_F16 : VOP3Inst <"v_fma_f16", VOP3_Profile<VOP_F16_F16_F16_F16>, fma>; def V_FMA_F16 : VOP3Inst <"v_fma_f16", VOP3_Profile<VOP_F16_F16_F16_F16>, fma>;
def V_INTERP_P1LL_F16 : VOP3Inst <"v_interp_p1ll_f16", VOP3_Profile<VOP_F32_F32_F16>>; def V_INTERP_P1LL_F16 : VOP3Inst <"v_interp_p1ll_f16", VOP3_Profile<VOP_F32_F32_F16>>;
def V_INTERP_P1LV_F16 : VOP3Inst <"v_interp_p1lv_f16", VOP3_Profile<VOP_F32_F32_F16_F16>>; def V_INTERP_P1LV_F16 : VOP3Inst <"v_interp_p1lv_f16", VOP3_Profile<VOP_F32_F32_F16_F16>>;
def V_INTERP_P2_F16 : VOP3Inst <"v_interp_p2_f16", VOP3_Profile<VOP_F16_F32_F16_F32>>; def V_INTERP_P2_F16 : VOP3Inst <"v_interp_p2_f16", VOP3_Profile<VOP_F16_F32_F16_F32>>;
def V_MAD_F16 : VOP3Inst <"v_mad_f16", VOP3_Profile<VOP_F16_F16_F16_F16>, fmad>; def V_MAD_F16 : VOP3Inst <"v_mad_f16", VOP3_Profile<VOP_F16_F16_F16_F16>, fmad>;
def V_MAD_U16 : VOP3Inst <"v_mad_u16", VOP3_Profile<VOP_I16_I16_I16_I16>>; def V_MAD_U16 : VOP3Inst <"v_mad_u16", VOP3_Profile<VOP_I16_I16_I16_I16>>;
def V_MAD_I16 : VOP3Inst <"v_mad_i16", VOP3_Profile<VOP_I16_I16_I16_I16>>; def V_MAD_I16 : VOP3Inst <"v_mad_i16", VOP3_Profile<VOP_I16_I16_I16_I16>>;
▲ Show 20 Lines • Show All 275 Lines • Show Last 20 Lines