This is an archive of the discontinued LLVM Phabricator instance.

[Polly] [CodeGen] Extend performance counter to track per-scop information.
ClosedPublic

Authored by bollu on May 31 2017, 6:53 AM.

Details

Summary

Previously, we would generate one performance counter for all scops.
Now, we generate both the old information, as well as a per-scop
performance counter to generate finer grained information.

This patch needed a way to generate a unique name for a Scop.
The start region, end region, and function name combined provides a
unique Scop name. So, Scop has a new public API to provide its start
and end region names.

Diff Detail

Repository
rL LLVM

Event Timeline

bollu created this revision.May 31 2017, 6:53 AM
grosser accepted this revision.Jun 1 2017, 10:52 PM

LGTM

include/polly/CodeGen/PerfMonitor.h
29 ↗(On Diff #100861)

We commonly align comments with the beginning of the description, in this case align "monitoring" with "The".

103 ↗(On Diff #100861)

Double space.

include/polly/ScopInfo.h
2331 ↗(On Diff #100861)

fst -> first element
snd -> second element

lib/CodeGen/PerfMonitor.cpp
182 ↗(On Diff #100861)

simply

This revision is now accepted and ready to land.Jun 1 2017, 10:52 PM
This revision was automatically updated to reflect the committed changes.