This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fix kernel arg segment size for amdgizcl
ClosedPublic

Authored by yaxunl on May 17 2017, 9:40 PM.

Download Raw Diff

Details

Reviewers

arsenm
t-tye

Commits

rGa618acf92379: [AMDGPU] Fix kernel arg segment size for amdgizcl
rL304482: [AMDGPU] Fix kernel arg segment size for amdgizcl

Diff Detail

Repository: rL LLVM

Event Timeline

yaxunl created this revision.May 17 2017, 9:40 PM

Herald added subscribers: t-tye, tpr, dstuttard and 3 others. · View Herald TranscriptMay 17 2017, 9:40 PM

ping

LGTM

This revision is now accepted and ready to land.Jun 1 2017, 1:06 PM

Closed by commit rL304482: [AMDGPU] Fix kernel arg segment size for amdgizcl (authored by yaxunl). · Explain WhyJun 1 2017, 2:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

lib/

Target/

AMDGPU/

AMDGPUSubtarget.h

3 lines

test/

CodeGen/

AMDGPU/

llvm.amdgcn.kernarg.segment.ptr.ll

2 lines

Diff 101114

llvm/trunk/lib/Target/AMDGPU/AMDGPUSubtarget.h

Show First 20 Lines • Show All 189 Lines • ▼ Show 20 Lines	bool isAmdHsaOS() const {
return TargetTriple.getOS() == Triple::AMDHSA;		return TargetTriple.getOS() == Triple::AMDHSA;
}		}

bool isMesa3DOS() const {		bool isMesa3DOS() const {
return TargetTriple.getOS() == Triple::Mesa3D;		return TargetTriple.getOS() == Triple::Mesa3D;
}		}

bool isOpenCLEnv() const {		bool isOpenCLEnv() const {
return TargetTriple.getEnvironment() == Triple::OpenCL;		return TargetTriple.getEnvironment() == Triple::OpenCL \|\|
		TargetTriple.getEnvironmentName() == "amdgizcl";
}		}

Generation getGeneration() const {		Generation getGeneration() const {
return Gen;		return Gen;
}		}

unsigned getWavefrontSize() const {		unsigned getWavefrontSize() const {
return WavefrontSize;		return WavefrontSize;
▲ Show 20 Lines • Show All 632 Lines • Show Last 20 Lines

llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.kernarg.segment.ptr.ll

	; RUN: llc -mtriple=amdgcn--amdhsa -mcpu=kaveri -verify-machineinstrs < %s \| FileCheck -check-prefixes=CO-V2,HSA,ALL,HSA-NOENV %s			; RUN: llc -mtriple=amdgcn--amdhsa -mcpu=kaveri -verify-machineinstrs < %s \| FileCheck -check-prefixes=CO-V2,HSA,ALL,HSA-NOENV %s
	; RUN: llc -mtriple=amdgcn--amdhsa-opencl -mcpu=kaveri -verify-machineinstrs < %s \| FileCheck -check-prefixes=CO-V2,HSA,ALL,HSA-OPENCL %s			; RUN: llc -mtriple=amdgcn--amdhsa-opencl -mcpu=kaveri -verify-machineinstrs < %s \| FileCheck -check-prefixes=CO-V2,HSA,ALL,HSA-OPENCL %s
	; RUN: llc -mtriple=amdgcn-mesa-mesa3d -verify-machineinstrs < %s \| FileCheck -check-prefixes=CO-V2,OS-MESA3D,MESA,ALL %s			; RUN: llc -mtriple=amdgcn-mesa-mesa3d -verify-machineinstrs < %s \| FileCheck -check-prefixes=CO-V2,OS-MESA3D,MESA,ALL %s
	; RUN: llc -mtriple=amdgcn-mesa-unknown -verify-machineinstrs < %s \| FileCheck -check-prefixes=OS-UNKNOWN,MESA,ALL %s			; RUN: llc -mtriple=amdgcn-mesa-unknown -verify-machineinstrs < %s \| FileCheck -check-prefixes=OS-UNKNOWN,MESA,ALL %s
				; RUN: llc -mtriple=amdgcn--amdhsa-amdgiz -mcpu=kaveri -verify-machineinstrs < %s \| FileCheck -check-prefixes=CO-V2,HSA,ALL,HSA-NOENV %s
				; RUN: llc -mtriple=amdgcn--amdhsa-amdgizcl -mcpu=kaveri -verify-machineinstrs < %s \| FileCheck -check-prefixes=CO-V2,HSA,ALL,HSA-OPENCL %s

	; ALL-LABEL: {{^}}test:			; ALL-LABEL: {{^}}test:
	; CO-V2: enable_sgpr_kernarg_segment_ptr = 1			; CO-V2: enable_sgpr_kernarg_segment_ptr = 1
	; CO-V2: s_load_dword s{{[0-9]+}}, s[4:5], 0xa			; CO-V2: s_load_dword s{{[0-9]+}}, s[4:5], 0xa

	; OS-UNKNOWN: s_load_dword s{{[0-9]+}}, s[0:1], 0xa			; OS-UNKNOWN: s_load_dword s{{[0-9]+}}, s[0:1], 0xa
	define amdgpu_kernel void @test(i32 addrspace(1)* %out) #1 {			define amdgpu_kernel void @test(i32 addrspace(1)* %out) #1 {
	%kernarg.segment.ptr = call noalias i8 addrspace(2)* @llvm.amdgcn.kernarg.segment.ptr()			%kernarg.segment.ptr = call noalias i8 addrspace(2)* @llvm.amdgcn.kernarg.segment.ptr()
	▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines