This is an archive of the discontinued LLVM Phabricator instance.

LTO: Don't verify modules twice in verifyMergedModuleOnce
ClosedPublic

Authored by aprantl on May 12 2017, 10:29 AM.

Details

Summary

There's a logic bug that causes the function to run the verifier twice if LTOStripInvalidDebugInfo is true.

Diff Detail

Repository
rL LLVM

Event Timeline

aprantl created this revision.May 12 2017, 10:29 AM
This revision is now accepted and ready to land.May 12 2017, 10:34 AM
davide requested changes to this revision.May 12 2017, 10:34 AM
davide added a subscriber: davide.

This is trivially correct, but I wonder whether we can fix this (i.e. feed a broken module, make sure we verify it and find it broken only once).

This revision now requires changes to proceed.May 12 2017, 10:34 AM

I don't think that is going to work, because of the report_fatal_error that also exits.

davide accepted this revision.May 12 2017, 2:23 PM

LGTM

This revision is now accepted and ready to land.May 12 2017, 2:23 PM
This revision was automatically updated to reflect the committed changes.