This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add wasm symbol table support to llvm-objdump
ClosedPublic

Authored by sbc100 on May 2 2017, 2:34 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.May 2 2017, 2:34 PM
sbc100 retitled this revision from [WebAssembly] Add wasm symbol table to llvm-objdump to [WebAssembly] Add wasm symbol table support to llvm-objdump.
dschuff added inline comments.May 2 2017, 2:54 PM
lib/Object/WasmObjectFile.cpp
672 ↗(On Diff #97502)

Do we need the extra return as we had before, for non-asserts builds?

sbc100 updated this revision to Diff 97509.May 2 2017, 3:00 PM
  • Store index values in WasmSymbol
sbc100 updated this revision to Diff 97691.May 3 2017, 11:09 AM
  • cleanup getSymbolFlags
sbc100 marked an inline comment as done.May 3 2017, 11:10 AM
sbc100 added inline comments.
lib/Object/WasmObjectFile.cpp
672 ↗(On Diff #97502)

I cleaned this up to me more like the other object format.

sbc100 updated this revision to Diff 97749.May 3 2017, 4:50 PM
sbc100 marked an inline comment as done.
  • Add missing breaks
dschuff accepted this revision.May 4 2017, 12:12 PM
This revision is now accepted and ready to land.May 4 2017, 12:12 PM
This revision was automatically updated to reflect the committed changes.