Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/Target/AMDGPU/SIFrameLowering.cpp | ||
---|---|---|
311–312 ↗ | (On Diff #97094) | This shouldn't be a recorded property of a function. Can you check MRI for whether the register has uses? |
test/CodeGen/AMDGPU/scratch-simple.ll | ||
5–7 ↗ | (On Diff #97094) | Copy paste from local-stack-slot-bug.ll. It would probably be better to merge the two tests rathe than having the exact same function repeated in multiple files. |
test/CodeGen/AMDGPU/scratch-simple.ll | ||
---|---|---|
5–7 ↗ | (On Diff #97094) | No. This patch renames local-stack-slot-bug.ll to scratch-simple.ll and adds new tests. |
lib/Target/AMDGPU/SIMachineFunctionInfo.cpp | ||
---|---|---|
74 ↗ | (On Diff #97140) | I still don't think you need this. You can directly set the input SGPR5 in the constructor here |
LGTM, except the test is much more complicated than it needs to be. Can have a small test with a volatile access to an alloca or something? These spill tests are big enough to slow down the test suite
Yeah, we could have a simpler test, but my approach is usually to copy an existing test and modify it, so it would help if we had such a test that screams "hey I'm a simple scratch buffer test!"