This is an archive of the discontinued LLVM Phabricator instance.

Differential D32599

[Safestack] Fix the canary test to catch the libc's message regarding stack smashing
ClosedPublic

Authored by kosarev on Apr 27 2017, 10:24 AM.

Details

Reviewers
kcc
filcab
eugenis
dvyukov
samsonov
Commits
rGe73af512a6ed: [Safestack] Fix the canary test to catch the libc's message regarding stack…
rCRT302628: [Safestack] Fix the canary test to catch the libc's message regarding stack…
rL302628: [Safestack] Fix the canary test to catch the libc's message regarding stack…
Summary

By default glibc writes its diagnostics directly to tty so the 2>&1 | redirection in the test doesn't catch the *** stack smashing detected *** message, which in turn breaks printing the lit's progress bar. By defining the LIBC_FATAL_STDERR_ environment variable we force glibc to direct diagnostic messages to stderr.

Diff Detail

Repository
rL LLVM

Event Timeline

kosarev created this revision.Apr 27 2017, 10:24 AM
eugenis accepted this revision.Apr 27 2017, 11:31 AM
This revision is now accepted and ready to land.Apr 27 2017, 11:31 AM
Closed by commit rL302628: [Safestack] Fix the canary test to catch the libc's message regarding stack… (authored by kosarev). · Explain WhyMay 10 2017, 1:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
test/
safestack/
3 lines

Diff 98414

compiler-rt/trunk/test/safestack/canary.c

// RUN: %clang_safestack -fno-stack-protector -D_FORTIFY_SOURCE=0 -g %s -o %t.nossp // RUN: %clang_safestack -fno-stack-protector -D_FORTIFY_SOURCE=0 -g %s -o %t.nossp
// RUN: %run %t.nossp 2>&1 | FileCheck --check-prefix=NOSSP %s // RUN: %run %t.nossp 2>&1 | FileCheck --check-prefix=NOSSP %s
// RUN: %clang_safestack -fstack-protector-all -D_FORTIFY_SOURCE=0 -g %s -o %t.ssp // RUN: %clang_safestack -fstack-protector-all -D_FORTIFY_SOURCE=0 -g %s -o %t.ssp
// RUN: not --crash %run %t.ssp 2>&1 | FileCheck -check-prefix=SSP %s // RUN: env LIBC_FATAL_STDERR_=1 not --crash %run %t.ssp 2>&1 | \
// RUN: FileCheck -check-prefix=SSP %s
// Test stack canaries on the unsafe stack. // Test stack canaries on the unsafe stack.
// REQUIRES: stable-runtime // REQUIRES: stable-runtime
#include <assert.h> #include <assert.h>
#include <stdio.h> #include <stdio.h>
#include <string.h> #include <string.h>
Show All 24 Lines