This is an archive of the discontinued LLVM Phabricator instance.

Differential D32427

Fix float abi for SUSE ARM triples
AbandonedPublic

Authored by ismail on Apr 24 2017, 5:03 AM.

Details

Reviewers
rengolin
compnerd
rovka
joerg
Summary

SUSE's ARM triples always ends with -gnueabi but all the targets are hard-float

Diff Detail

Event Timeline

ismail created this revision.Apr 24 2017, 5:03 AM
Harbormaster completed remote builds in B5804: Diff 96381.Apr 24 2017, 5:03 AM
Herald added a subscriber: aemerson. · View Herald TranscriptApr 24 2017, 5:03 AM
ismail updated this revision to Diff 96382.Apr 24 2017, 5:03 AM

Fix typo

Harbormaster completed remote builds in B5805: Diff 96382.Apr 24 2017, 5:03 AM
rengolin added reviewers: compnerd, rovka, joerg.Apr 24 2017, 5:47 AM
rengolin edited edge metadata.

I'm not sure this will work at all. Not because it doesn't make sense (it does), but because of several bugs in the soft vs. hard float implementation in the Triple related classes all the way to the back-end.

I'm adding other folks to discuss.

joerg edited edge metadata.Apr 24 2017, 6:06 AM

I'm not sure the results will really work that well either.

ismail added a comment.Apr 24 2017, 6:15 AM

I am open to suggestions on how to do this correctly. The problem as stated is all SUSE ARM triples end with -gnueabi but they are all hard-float. Environment handling in LLVM seems to only check for the last part of the triple and not the whole string.

compnerd edited edge metadata.Apr 24 2017, 5:27 PM

I think that you should mutate the environment in the canonicalisation phase of the triple. That will allow you to use armv7-suse-linux-gnueabi and armv7-suse-linux-gnueabihf in the frontend, but have the backend always get armv7-suse-linux-gnueabihf.

ismail abandoned this revision.Apr 25 2017, 12:59 AM

compnerd has a better fix.

Revision Contents

PathSize
lib/
Driver/
ToolChains/
Arch/
4 lines
test/
Driver/
6 lines

Diff 96382

lib/Driver/ToolChains/Arch/ARM.cpp

Show First 20 Lines • Show All 221 Lines • ▼ Show 20 Lines default:
if (Triple.getOS() != llvm::Triple::UnknownOS || if (Triple.getOS() != llvm::Triple::UnknownOS ||
!Triple.isOSBinFormatMachO()) !Triple.isOSBinFormatMachO())
D.Diag(diag::warn_drv_assuming_mfloat_abi_is) << "soft"; D.Diag(diag::warn_drv_assuming_mfloat_abi_is) << "soft";
break; break;
} }
} }
} }
// SUSE triples end with -gnueabi but all targets are hard-float
if (Triple.getVendor() == llvm::Triple::SUSE)
ABI = FloatABI::Hard;
assert(ABI != FloatABI::Invalid && "must select an ABI"); assert(ABI != FloatABI::Invalid && "must select an ABI");
return ABI; return ABI;
} }
void arm::getARMTargetFeatures(const ToolChain &TC, void arm::getARMTargetFeatures(const ToolChain &TC,
const llvm::Triple &Triple, const llvm::Triple &Triple,
const ArgList &Args, const ArgList &Args,
ArgStringList &CmdArgs, ArgStringList &CmdArgs,
▲ Show 20 Lines • Show All 310 Lines • Show Last 20 Lines

test/Driver/linux-as.c

Show First 20 Lines • Show All 168 Lines • ▼ Show 20 Lines
// RUN: %clang -target s390x-linux -### -no-integrated-as -c %s 2>&1 \ // RUN: %clang -target s390x-linux -### -no-integrated-as -c %s 2>&1 \
// RUN: | FileCheck -check-prefix=CHECK-Z-DEFAULT-ARCH %s // RUN: | FileCheck -check-prefix=CHECK-Z-DEFAULT-ARCH %s
// CHECK-Z-DEFAULT-ARCH: as{{.*}} "-march=z10" // CHECK-Z-DEFAULT-ARCH: as{{.*}} "-march=z10"
// //
// RUN: %clang -target s390x-linux -march=z196 -### \ // RUN: %clang -target s390x-linux -march=z196 -### \
// RUN: -no-integrated-as -c %s 2>&1 \ // RUN: -no-integrated-as -c %s 2>&1 \
// RUN: | FileCheck -check-prefix=CHECK-Z-ARCH-Z196 %s // RUN: | FileCheck -check-prefix=CHECK-Z-ARCH-Z196 %s
// CHECK-Z-ARCH-Z196: as{{.*}} "-march=z196" // CHECK-Z-ARCH-Z196: as{{.*}} "-march=z196"
//
// RUN: %clang -target armv7hl-suse-linux-gnueabi -### \
// RUN: -no-integrated-as -c %s 2>&1 \
// RUN: | FileCheck -check-prefix=CHECK-SUSE-ARMV7 %s
// CHECK-SUSE-ARMV7: as{{.*}}" "-mfloat-abi=hard"