[LLDB][MIPS] Fix TestMiExec.py failure
Needs ReviewPublic

Authored by nitesh.jain on Fri, Apr 21, 12:40 AM.

Details

Reviewers
ki.stfu
labath
Summary

Call to s_MyFunction may not follow immediately after g_MyFunction. There might be some instructions in between to restore caller-saved registers. We need to get past these instructions with a step to reach call to s_MyFunction.

Diff Detail

nitesh.jain created this revision.Fri, Apr 21, 12:40 AM
labath accepted this revision.Fri, Apr 21, 2:10 AM

sounds reasonable

This revision is now accepted and ready to land.Fri, Apr 21, 2:10 AM
ki.stfu requested changes to this revision.Fri, Apr 21, 3:14 AM

Thanks for catching this! Could you update this CL to let me commit it?

packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py
287–289

Remove this.

303–310

Please do like this.

321–330
it = self.expect(["\*stopped,reason=\"end-stepping-range\".+?main\.cpp\",line=\"30\"",
                  "\*stopped,reason=\"end-stepping-range\".+?main\.cpp\",line=\"29\""])
if it == 1:
    # Call to s_MyFunction may not follow immediately after g_MyFunction.  There might be
    # some instructions in between to restore caller-saved registers.   
    self.runCmd("-exec-step")
    self.expect("\^running")
    self.expect(
        "\*stopped,reason=\"end-stepping-range\".+?main\.cpp\",line=\"30\"")
packages/Python/lldbsuite/test/tools/lldb-mi/control/main.cpp
29–30 ↗(On Diff #96105)

Revert this

This revision now requires changes to proceed.Fri, Apr 21, 3:14 AM
clayborg resigned from this revision.Fri, Apr 21, 8:40 AM

Update diff as per suggestion.

nitesh.jain marked an inline comment as done.EditedMon, Apr 24, 3:23 AM

Thanks for catching this! Could you update this CL to let me commit it?

Yes , Please commit it.

Thanks