This is an archive of the discontinued LLVM Phabricator instance.

[InstSimplify] Deduce correct type for vector gep
ClosedPublic

Authored by davide on Apr 18 2017, 10:44 AM.

Diff Detail

Event Timeline

davide created this revision.Apr 18 2017, 10:44 AM
davide added a reviewer: loladiro.
davide added a reviewer: dblaikie.
filcab accepted this revision.Apr 19 2017, 6:26 AM

LGTM

This revision is now accepted and ready to land.Apr 19 2017, 6:26 AM
spatel added a subscriber: spatel.Apr 19 2017, 6:52 AM

Since we already have a test file specifically for vector gep simplifications (test/Transforms/InstSimplify/vector_gep.ll), can you please add these new tests there? I find it easier to locate and fix bugs when related tests are co-located. A comment/link back to http://bugs.llvm.org/show_bug.cgi?id=32697 above the regression test also saves time for future bug hunting. Thanks!

Since we already have a test file specifically for vector gep simplifications (test/Transforms/InstSimplify/vector_gep.ll), can you please add these new tests there? I find it easier to locate and fix bugs when related tests are co-located. A comment/link back to http://bugs.llvm.org/show_bug.cgi?id=32697 above the regression test also saves time for future bug hunting. Thanks!

Sure.

This revision was automatically updated to reflect the committed changes.