This is an archive of the discontinued LLVM Phabricator instance.

Emit warning when umbrella directory does not exists

Authored by yamaguchi on Apr 16 2017, 6:16 AM.



This is a patch for [1].

In /lib/Lex/ModuleMap.cpp, it was checking if umbrella directory exists, and emitted error if the directory doesn't exists.
So I changed error to warning, because in [1] discussion it was said "this should probably be at most a warning".

However, I'm not sure which file to add test case, so I would like to ask for an advice.


Diff Detail

Event Timeline

yamaguchi created this revision.Apr 16 2017, 6:16 AM
v.g.vassilev edited edge metadata.

The test case seems at a reasonable place to me.

This revision is now accepted and ready to land.Apr 18 2017, 11:44 AM
v.g.vassilev closed this revision.Apr 18 2017, 2:11 PM

Landed in r300594.