This is an archive of the discontinued LLVM Phabricator instance.

Define __tls_get_addr as a hidden symbol even for ARM or MIPS.
ClosedPublic

Authored by ruiu on Apr 13 2017, 2:20 PM.

Details

Summary

addIgnored defines a given symbol even if there is no existing
symbol with the same name. So, even if libc provides __tls_get_addr,
we should still be able to call addIgnored.

Event Timeline

ruiu created this revision.Apr 13 2017, 2:20 PM
peter.smith accepted this revision.Apr 19 2017, 3:13 AM

I agree that the code is now redundant and can be removed. It used to be the case that addIgnored() would define the symbol even when there was an existing definition and cause a duplicate error. It looks like this was later fixed in -r287125 Don't error if __tls_get_addr is defined.

Apologies for the delay in responding, I've just come back from Easter break.

This revision is now accepted and ready to land.Apr 19 2017, 3:13 AM
This revision was automatically updated to reflect the committed changes.