This is an archive of the discontinued LLVM Phabricator instance.

Use 0-padding for i386 and arm print format specifiers
ClosedPublic

Authored by fjricci on Apr 12 2017, 7:28 AM.

Reviewers

spetrovic
m.ostapenko

Commits

Summary

This is used for the other architectures in print_address, but is
missing from i386 and arm.

Build Status

Buildable 5488
Build 5488: arc lint + arc unit

lgtm

This revision is now accepted and ready to land.Apr 12 2017, 7:34 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

test/

sanitizer_common/

2 lines

	#include <stdio.h>			#include <stdio.h>
	#include <stdarg.h>			#include <stdarg.h>

	void print_address(const char *str, int n, ...) {			void print_address(const char *str, int n, ...) {
	fprintf(stderr, "%s", str);			fprintf(stderr, "%s", str);
	va_list ap;			va_list ap;
	va_start(ap, n);			va_start(ap, n);
	while (n--) {			while (n--) {
	void p = va_arg(ap, void );			void p = va_arg(ap, void );
	#if defined(__x86_64__) \|\| defined(__aarch64__) \|\| defined(__powerpc64__)			#if defined(__x86_64__) \|\| defined(__aarch64__) \|\| defined(__powerpc64__)
	// On FreeBSD, the %p conversion specifier works as 0x%x and thus does not			// On FreeBSD, the %p conversion specifier works as 0x%x and thus does not
	// match to the format used in the diagnotic message.			// match to the format used in the diagnotic message.
	fprintf(stderr, "0x%012lx ", (unsigned long) p);			fprintf(stderr, "0x%012lx ", (unsigned long) p);
	#elif defined(__i386__) \|\| defined(__arm__)			#elif defined(__i386__) \|\| defined(__arm__)
	fprintf(stderr, "0x%8lx ", (unsigned long) p);			fprintf(stderr, "0x%08lx ", (unsigned long) p);
	#elif defined(__mips64)			#elif defined(__mips64)
	fprintf(stderr, "0x%010lx ", (unsigned long) p);			fprintf(stderr, "0x%010lx ", (unsigned long) p);
	#endif			#endif
	}			}
	fprintf(stderr, "\n");			fprintf(stderr, "\n");
	}			}