This is an archive of the discontinued LLVM Phabricator instance.

Subtarget support for parametrized register class information
ClosedPublic

Authored by kparzysz on Apr 11 2017, 2:18 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

asb accepted this revision.Apr 20 2017, 5:15 AM

Looks good to me.

This revision is now accepted and ready to land.Apr 20 2017, 5:15 AM
This revision was automatically updated to reflect the committed changes.
MatzeB added inline comments.Jan 18 2018, 10:42 PM
llvm/trunk/include/llvm/Target/TargetSubtargetInfo.h
113–114 ↗(On Diff #115275)

Please add a comment to public API.

Looking at how getHwMode() is used at the moment I also wonder if you need this to be a virtual function in the base class. Right now it seems to be only ever calls from specific classes, so it may be enough to let tablegen generate it in the subclasses. That way maybe you can also use a more specific type than unsigned.