This is an archive of the discontinued LLVM Phabricator instance.

CMake: Fix sphinx build with standalone clang
ClosedPublic

Authored by tstellar on Apr 4 2017, 5:17 PM.

Details

Reviewers
chandlerc
beanz
Summary

This code is copied from llvm/cmake/config-ix.cmake. Would it be better
to refactor this code and put it in
llvm/cmake/modules/AddSphinxTarget.cmake ?

Event Timeline

tstellar created this revision.Apr 4 2017, 5:17 PM
tstellar updated this revision to Diff 94145.Apr 4 2017, 5:26 PM

Remove redundant find_package(Sphinx)

See also: D23758, for SphInx + doxygen + relevant options.

beanz edited edge metadata.Apr 5 2017, 1:13 PM

I think putting this into AddSphinxTarget.cmake would be a better way to handle it. Also I have one small inline comment.

CMakeLists.txt
177

If tis code can be run more than once you also need to add AND NOT TARGET sphinx to the condition here.

tstellar updated this revision to Diff 94390.Apr 6 2017, 10:30 AM

Move most logic into AddSphinxTarget.cmake in the llvm tree.

beanz accepted this revision.May 31 2017, 11:23 AM

LGTM.

This revision is now accepted and ready to land.May 31 2017, 11:23 AM
tstellar closed this revision.Jun 9 2017, 5:53 AM