This is an archive of the discontinued LLVM Phabricator instance.

Enable leak detection on linux-i686 by default
ClosedPublic

Authored by fjricci on Mar 29 2017, 7:16 AM.

Download Raw Diff

Details

Reviewers

kcc
vitalybuka
m.ostapenko
kubamracek

Commits

rG2aa23e892c14: Enable leak detection on linux-i686 by default
rCRT299082: Enable leak detection on linux-i686 by default
rL299082: Enable leak detection on linux-i686 by default

Summary

This is already assumed by the test suite, and by
asan_flags.cc.

Diff Detail

Repository: rL LLVM

Event Timeline

fjricci created this revision.Mar 29 2017, 7:16 AM

Harbormaster completed remote builds in B5156: Diff 93372.Mar 29 2017, 7:16 AM

As discussed in D31430, looks like 32-bit linux leak detection should be enabled by default.

fjricci added a child revision: D31307: Enable builds of darwin lsan by default.Mar 29 2017, 7:17 AM

Looks good, thank you.

This revision is now accepted and ready to land.Mar 29 2017, 7:21 AM

fjricci mentioned this in D31430: Disable asan leak tests on i386 linux.Mar 29 2017, 7:47 AM

Closed by commit rL299082: Enable leak detection on linux-i686 by default (authored by fjricci). · Explain WhyMar 30 2017, 7:18 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

compiler-rt/

trunk/

lib/

sanitizer_common/

sanitizer_flags.inc

3 lines

Diff 93477

compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.inc

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	COMMON_FLAG(
"append executable name to logs (as in \"log_path.exe_name.pid\").")		"append executable name to logs (as in \"log_path.exe_name.pid\").")
COMMON_FLAG(		COMMON_FLAG(
bool, log_to_syslog, SANITIZER_ANDROID \|\| SANITIZER_MAC,		bool, log_to_syslog, SANITIZER_ANDROID \|\| SANITIZER_MAC,
"Write all sanitizer output to syslog in addition to other means of "		"Write all sanitizer output to syslog in addition to other means of "
"logging.")		"logging.")
COMMON_FLAG(		COMMON_FLAG(
int, verbosity, 0,		int, verbosity, 0,
"Verbosity level (0 - silent, 1 - a bit of output, 2+ - more output).")		"Verbosity level (0 - silent, 1 - a bit of output, 2+ - more output).")
COMMON_FLAG(bool, detect_leaks, SANITIZER_WORDSIZE == 64,		COMMON_FLAG(bool, detect_leaks, true, "Enable memory leak detection.")
"Enable memory leak detection.")
COMMON_FLAG(		COMMON_FLAG(
bool, leak_check_at_exit, true,		bool, leak_check_at_exit, true,
"Invoke leak checking in an atexit handler. Has no effect if "		"Invoke leak checking in an atexit handler. Has no effect if "
"detect_leaks=false, or if __lsan_do_leak_check() is called before the "		"detect_leaks=false, or if __lsan_do_leak_check() is called before the "
"handler has a chance to run.")		"handler has a chance to run.")
COMMON_FLAG(bool, allocator_may_return_null, false,		COMMON_FLAG(bool, allocator_may_return_null, false,
"If false, the allocator will crash instead of returning 0 on "		"If false, the allocator will crash instead of returning 0 on "
"out-of-memory.")		"out-of-memory.")
▲ Show 20 Lines • Show All 166 Lines • Show Last 20 Lines