Page MenuHomePhabricator

[Builtin] Unxfail tests for armhf
ClosedPublic

Authored by weimingz on Mar 28 2017, 6:01 PM.

Details

Summary

Originally, a few tests fail for armhf target due to:

  1. COMPILER_RT_ARMHF_TARGET was not set when building the lib
  2. COMPILER_RT_ABI should not be defined as __attribute__((pcs("aapcs"))) for armhf when building for both lib and tests

This address https://bugs.llvm.org//show_bug.cgi?id=32261

mulsc3_test.c is a newly exposed issue, which will be addressed separately.

Diff Detail

Event Timeline

weimingz created this revision.Mar 28 2017, 6:01 PM
compnerd accepted this revision.Mar 28 2017, 6:21 PM
This revision is now accepted and ready to land.Mar 28 2017, 6:21 PM
This revision was automatically updated to reflect the committed changes.

Interestingly, mulsc3_test.c XPASSed. Looks like the compiltion line has no hardfp flag, so the problem was not exposed. In my local build.

http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/1202/steps/ninja%20check%202/logs/XPASS%3A%20Builtins-armhf-linux%3A%3A%20mulsc3_test.c

We can remove the XFAIL for now

pushed r298997 that removes XFAIL