This is an archive of the discontinued LLVM Phabricator instance.

Add docs for libunwind
ClosedPublic

Authored by jroelofs on Mar 26 2017, 8:59 AM.

Details

Reviewers
compnerd
EricWF
Summary

I'm still iffy about the build goop for this. I started mostly cargo-culting the stuff from libcxx, but couldn't get that to work. What's in the patch seems to work for the standalone build, but does not work for in tree builds (and I have no idea why).

Comments / corrections / feedback would be much appreciated.

Diff Detail

Event Timeline

jroelofs created this revision.Mar 26 2017, 8:59 AM
krytarowski added inline comments.
docs/index.rst
52

NetBSD amd64 Clang, GCC confirmed

jroelofs updated this revision to Diff 93074.Mar 26 2017, 9:06 AM
jroelofs marked an inline comment as done.
compnerd edited edge metadata.Mar 26 2017, 9:24 AM

What happens when you try building it in tree?

docs/index.rst
83

ITYM libunwind :)

What happens when you try building it in tree?

The docs-libunwind-html target is missing, and the docs don't get built.

docs/index.rst
83

doh

jroelofs updated this revision to Diff 93075.Mar 26 2017, 9:28 AM
jroelofs marked 2 inline comments as done.
EricWF accepted this revision.Mar 27 2017, 8:13 PM

This LGTM. We should also get a bot setup to build it.

This revision is now accepted and ready to land.Mar 27 2017, 8:13 PM

What happens when you try building it in tree?

The docs-libunwind-html target is missing, and the docs don't get built.

Shouldn't that be what happens when libunwind is built "out-of-tree"/standalone, not the other way around?

What happens when you try building it in tree?

The docs-libunwind-html target is missing, and the docs don't get built.

Shouldn't that be what happens when libunwind is built "out-of-tree"/standalone, not the other way around?

"is" != "ought". That's what /is/ happening, not necessarily what we want to happen.

What happens when you try building it in tree?

The docs-libunwind-html target is missing, and the docs don't get built.

Shouldn't that be what happens when libunwind is built "out-of-tree"/standalone, not the other way around?

"is" != "ought". That's what /is/ happening, not necessarily what we want to happen.

And FWIW, it looks like libcxx's docs behave the same way... So this might be a problem with the way the runtimes dir works.

jroelofs closed this revision.Mar 28 2017, 8:34 AM

r298922

Review for adding a builder in: D31422