This is an archive of the discontinued LLVM Phabricator instance.

Differential D31300

Disable use_tls_dynamic on 32-bit linux
ClosedPublic

Authored by fjricci on Mar 23 2017, 1:07 PM.

Details

Reviewers
kcc
m.ostapenko
kubamracek
Commits
rG0add37927c8b: Disable use_tls_dynamic on 32-bit linux
rCRT298847: Disable use_tls_dynamic on 32-bit linux
rL298847: Disable use_tls_dynamic on 32-bit linux
Summary

This test fails with a false negative due to an unrelated change.
Since we expect a number of false negatives on 32-bit lsan,
disable this test on linux-i386 and linux-i686.

Diff Detail

Event Timeline

fjricci created this revision.Mar 23 2017, 1:07 PM
fjricci added a parent revision: D31291: Use pthreads for thread-local lsan allocator cache on darwin.Mar 23 2017, 2:14 PM
fjricci removed a parent revision: D31291: Use pthreads for thread-local lsan allocator cache on darwin.
fjricci added a child revision: D31291: Use pthreads for thread-local lsan allocator cache on darwin.
kubamracek edited edge metadata.Mar 23 2017, 2:15 PM

Shouldn't this be "UNSUPPORTED" instead of "XFAIL"?

m.ostapenko edited edge metadata.Mar 23 2017, 11:25 PM
In D31300#709284, @kubamracek wrote:

Shouldn't this be "UNSUPPORTED" instead of "XFAIL"?

Agree, please use "UNSUPPORTED".

fjricci updated this revision to Diff 92937.Mar 24 2017, 6:55 AM

Use UNSUPPORTED

Harbormaster completed remote builds in B5053: Diff 92937.Mar 24 2017, 6:55 AM
Closed by commit rL298847: Disable use_tls_dynamic on 32-bit linux (authored by fjricci). · Explain WhyMar 27 2017, 7:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
lsan/
TestCases/
1 line

Diff 92937

test/lsan/TestCases/use_tls_dynamic.cc

// Test that dynamically allocated TLS space is included in the root set. // Test that dynamically allocated TLS space is included in the root set.
// RUN: LSAN_BASE="detect_leaks=1:report_objects=1:use_stacks=0:use_registers=0:use_ld_allocations=0" // RUN: LSAN_BASE="detect_leaks=1:report_objects=1:use_stacks=0:use_registers=0:use_ld_allocations=0"
// RUN: %clangxx %s -DBUILD_DSO -fPIC -shared -o %t-so.so // RUN: %clangxx %s -DBUILD_DSO -fPIC -shared -o %t-so.so
// RUN: %clangxx_lsan %s -o %t // RUN: %clangxx_lsan %s -o %t
// RUN: LSAN_OPTIONS=$LSAN_BASE:"use_tls=0" not %run %t 2>&1 | FileCheck %s // RUN: LSAN_OPTIONS=$LSAN_BASE:"use_tls=0" not %run %t 2>&1 | FileCheck %s
// RUN: LSAN_OPTIONS=$LSAN_BASE:"use_tls=1" %run %t 2>&1 // RUN: LSAN_OPTIONS=$LSAN_BASE:"use_tls=1" %run %t 2>&1
// RUN: LSAN_OPTIONS="" %run %t 2>&1 // RUN: LSAN_OPTIONS="" %run %t 2>&1
// UNSUPPORTED: i386-linux,i686-linux
#ifndef BUILD_DSO #ifndef BUILD_DSO
#include <assert.h> #include <assert.h>
#include <dlfcn.h> #include <dlfcn.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string> #include <string>
#include "sanitizer_common/print_address.h" #include "sanitizer_common/print_address.h"
Show All 36 Lines