Page MenuHomePhabricator

Add stub for PluginProcessNetBSD
ClosedPublic

Authored by krytarowski on Mar 20 2017, 10:21 AM.

Details

Summary

This is the base for introduction of further features to support Process Tracing on NetBSD, in local and remote setup.

This code is also a starting point to synchronize the development with other BSDs. Currently NetBSD is ahead and other systems can catch up.

Sponsored by <The NetBSD Foundation>

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski created this revision.Mar 20 2017, 10:21 AM

I have got a few local changes that conflict with D31131, this is why I will hold on them unless @kettenis does not intend to land his patch in the coming days.

labath edited edge metadata.Mar 21 2017, 4:53 AM

I like the idea of adding boilerplate first, so that we can than better focus on the important stuff later. However, I think you've have gone a bit too far with it -- you introduce a lot of functions I am pretty sure will not be necessary for your case, or that should be handled differently (software single stepping stuff, handling of linux thread stopping, ...).

Could we trim this down to just the functions that are necessary to get this building (basically just virtual overrides -- no private functions or members)? Those can be always added along with the patch that implements them, and then we will be in a better position to review it.

I like the idea of adding boilerplate first, so that we can than better focus on the important stuff later. However, I think you've have gone a bit too far with it -- you introduce a lot of functions I am pretty sure will not be necessary for your case, or that should be handled differently (software single stepping stuff, handling of linux thread stopping, ...).

Could we trim this down to just the functions that are necessary to get this building (basically just virtual overrides -- no private functions or members)? Those can be always added along with the patch that implements them, and then we will be in a better position to review it.

I will go for it. Your idea is good. I originally planned to trim unneeded chunks afterwards, but this direction is cleaner.

krytarowski edited the summary of this revision. (Show Details)

Cut down the unused functions from the Native Process NetBSD Plugin.

labath accepted this revision.Mar 21 2017, 9:20 AM

Heh... I did not expect it would get this small, but ok. :)

This revision is now accepted and ready to land.Mar 21 2017, 9:20 AM
krytarowski closed this revision.Mar 21 2017, 10:42 AM