This is an archive of the discontinued LLVM Phabricator instance.

Fix evaluation of LLVM_DEFINITIONS
ClosedPublic

Authored by sepavloff on Mar 19 2017, 6:46 AM.

Details

Summary

CMake variable LLVM_DEFINITIONS collects preprocessor definitions provided
for host compiler that builds llvm components. A function
add_llvm_definitions was introduced in AddLLVMDefinitions.cmake to keep
track of these definitions and was intended to be a replacement for CMake
command add_definitions. Actually in many cases add_definitions is still
used and the content of LLVM_DEFINITIONS is not actual now. On the other
hand the current version of CMake allows getting set of definitions in a
more convenient way. This fix implements evaluation of the variable by
reading corresponding cmake property.

Diff Detail

Repository
rL LLVM

Event Timeline

sepavloff created this revision.Mar 19 2017, 6:46 AM
beanz accepted this revision.Mar 20 2017, 1:30 PM

This looks like a great cleanup. Thanks!

This revision is now accepted and ready to land.Mar 20 2017, 1:30 PM
This revision was automatically updated to reflect the committed changes.