This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Add vcmp MC test
ClosedPublic

Authored by SjoerdMeijer on Mar 8 2017, 9:22 AM.

Details

Summary

Minor cleanup in ARMInstrVFP.td: removed some FIXMEs and added a MC test for vcmp that was actually missing.

Diff Detail

Event Timeline

SjoerdMeijer created this revision.Mar 8 2017, 9:22 AM
rengolin edited edge metadata.Mar 8 2017, 2:49 PM

Seems trivial. Comments inline.

test/MC/ARM/simple-fp-encoding.s
52

What about the vcvt encodings?

SjoerdMeijer added inline comments.Mar 9 2017, 1:40 AM
test/MC/ARM/simple-fp-encoding.s
52

The different vcvt tests are already present in fullfp16.s and in simple-fp-encoding.s (this file).

rengolin accepted this revision.Mar 9 2017, 3:37 AM

Ok. LGTM, thanks!

This revision is now accepted and ready to land.Mar 9 2017, 3:37 AM
This revision was automatically updated to reflect the committed changes.