Page MenuHomePhabricator

[libcxxabi] Clean up macro usage
ClosedPublic

Authored by rs on Feb 28 2017, 7:02 AM.

Diff Detail

Event Timeline

rs created this revision.Feb 28 2017, 7:02 AM
EricWF edited edge metadata.Feb 28 2017, 10:05 PM

I renamed LIBCXXABI_ARM_EHABI to _LIBCXXABI_ARM_EHABI so you'll have to merge this change with that.

Other than that this LGTM.

rs updated this revision to Diff 90150.Mar 1 2017, 3:24 AM

Thanks for reviewing. Before I commit could you tell me if I need to update any build systems e.g. buildbots ?

rmaprath edited edge metadata.Mar 1 2017, 3:30 AM
In D30459#689461, @rs wrote:

Thanks for reviewing. Before I commit could you tell me if I need to update any build systems e.g. buildbots ?

Those two options are not used by any of the current public builders, so I think it's safe to commit.

If something breaks, we can revert and have a look :)

rs added a comment.Mar 1 2017, 3:53 AM

ok thanks.

This revision was automatically updated to reflect the committed changes.