This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Runtime metadata fixes:
ClosedPublic

Authored by kzhuravl on Feb 24 2017, 1:39 PM.

Details

Summary
  1. Verify that runtime metadata is actually valid runtime metadata when assembling, otherwise we could accept the following when assembling, but ocl runtime will reject it:
.amdgpu_runtime_metadata
{ amd.MDVersion: [ 2, 1 ], amd.RandomUnknownKey, amd.IsaInfo:
  1. Make IsaInfo optional, and always emit it.

Diff Detail

Repository
rL LLVM

Event Timeline

kzhuravl created this revision.Feb 24 2017, 1:39 PM
arsenm accepted this revision.Feb 24 2017, 1:47 PM

LGTM

lib/Target/AMDGPU/MCTargetDesc/AMDGPURuntimeMD.cpp
379–383 ↗(On Diff #89716)

You don't need the llvm::'s

test/MC/AMDGPU/runtime-metadata-invalid-1.s
106–125 ↗(On Diff #89716)

You can drop the extra comments here

This revision is now accepted and ready to land.Feb 24 2017, 1:47 PM
yaxunl accepted this revision.Feb 24 2017, 2:05 PM

LGTM. Thanks!

This revision was automatically updated to reflect the committed changes.
kzhuravl marked 2 inline comments as done.
llvm/trunk/test/MC/AMDGPU/hsa.s