This is an archive of the discontinued LLVM Phabricator instance.

[.gitignore] Update .gitignore to ignore a nested build directory
ClosedPublic

Authored by beanz on Feb 24 2017, 10:57 AM.

Details

Summary

A number of tools and common workflows include putting a build directory inside the source checkout under the folder "build". Adding this to .gitignore seems useful.

As an example, the CMake Tools plugin for VSCode does this.

Event Timeline

beanz created this revision.Feb 24 2017, 10:57 AM
zturner accepted this revision.Feb 24 2017, 11:00 AM

Seems fine to me, I know a lot of peoples' standard workflows involves putting the build directory in the root anyway.

One thing I can't tell by looking at the file paths - Is this in the LLDB directory or the LLVM directory? If it's in the LLDB directory then do we need it at the top level LLVM directory too? Although since it seems likely we'll eventually end up on mono-repo, maybe we need it in all project directories.

This revision is now accepted and ready to land.Feb 24 2017, 11:00 AM

This is for LLVM. Will land shortly.

MatzeB added a subscriber: MatzeB.Feb 24 2017, 11:45 AM

I usually put my personal ignore patterns like build directories into .git/info/exclude. Though I wouldn't object this commit either, it shouldn't hurt anyone.

This revision was automatically updated to reflect the committed changes.