This is an archive of the discontinued LLVM Phabricator instance.

[X86][SSE] Enable post-legalize vXi64 shuffle combining on 32-bit targets
ClosedPublic

Authored by RKSimon on Feb 21 2017, 9:42 AM.

Details

Summary

Long ago (2010 according to svn blame), combineShuffle probably needed to prevent the accidental creation of illegal i64 types but there doesn't appear to be any combines that can cause this any more as they all have their own legality checks.

Diff Detail

Repository
rL LLVM

Event Timeline

RKSimon created this revision.Feb 21 2017, 9:42 AM
andreadb added inline comments.Feb 21 2017, 10:57 AM
test/CodeGen/X86/dagcombine-cse.ll
1–2 ↗(On Diff #89238)

Do you think that there is still value in keeping this test?

If we want to keep this test, then I suggest to rewrite the RUN line (i.e. use FileCheck instead of grep, and regenerate the test using the update script).

RKSimon added inline comments.Feb 21 2017, 11:19 AM
test/CodeGen/X86/dagcombine-cse.ll
1–2 ↗(On Diff #89238)

It seems to be interested in the stats dump as opposed to the codegen so we can't as easily pipe into FileCheck (and update_llc_test_checks.py). But maybe I'm over thinking this and they really were just wanting to count the number of instructions.....

I'll investigate alternatives because I too have a loathing for the old grep style tests.....

RKSimon updated this revision to Diff 89411.Feb 22 2017, 12:48 PM

Rebased against the regenerated dagcombine-cse.ll

craig.topper accepted this revision.Mar 3 2017, 2:11 PM
This revision is now accepted and ready to land.Mar 3 2017, 2:11 PM
This revision was automatically updated to reflect the committed changes.