Page MenuHomePhabricator

Go binding: Add methods for missing PassManagerBuilder C APIs
ClosedPublic

Authored by rhysd on Feb 16 2017, 5:37 AM.

Details

Summary

Hi team,

I found some APIs are lack in Go binding. So I added them as attached patch.
Added APIs are below:

  • LLVMPassManagerBuilderPopulateLTOPassManager
  • LLVMPassManagerBuilderSetDisableUnitAtATime
  • LLVMPassManagerBuilderSetDisableUnrollLoops
  • LLVMPassManagerBuilderSetDisableSimplifyLibCalls
  • LLVMPassManagerBuilderUseInlinerWithThreshold

I created this patch against rL295310. LLVM and Go bindings can be built with this patch.

This is my first attempt to send a patch to LLVM.
So could you please point out if something is wrong. I'll fix it as soon as possible.

Thanks.

Diff Detail

Repository
rL LLVM

Event Timeline

rhysd created this revision.Feb 16 2017, 5:37 AM
axw accepted this revision.Feb 16 2017, 5:08 PM

LGTM, thanks.

This revision is now accepted and ready to land.Feb 16 2017, 5:08 PM
rhysd added a comment.EditedFeb 16 2017, 9:11 PM

Thank you for your review and approve. I don't have a permission to commit. Could you please commit this patch to repository?

This revision was automatically updated to reflect the committed changes.
axw added a comment.Feb 16 2017, 9:53 PM

Thank you for your review and approve. I don't have a permission to commit. Could you please commit this patch to repository?

Done. Thank you for your contribution.

@axw Thank you so much for quick response!