This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][asan|win] Fix ASAN exception handler missing import
ClosedPublic

Authored by etienneb on Feb 15 2017, 11:06 AM.

Download Raw Diff

Details

Reviewers

Commits

rGb69639e217f9: [compiler-rt][asan|win] Fix ASAN exception handler missing import
rCRT295232: [compiler-rt][asan|win] Fix ASAN exception handler missing import
rL295232: [compiler-rt][asan|win] Fix ASAN exception handler missing import

Summary

This patch is adding a missing ASAN API redirection from an instrumented DLL.
The bug was introduced here:

https://reviews.llvm.org/D29463

This is causing this chromium bug:

https://bugs.chromium.org/p/chromium/issues/detail?id=692580

Diff Detail

Build Status

Buildable 4008
Build 4008: arc lint + arc unit

Event Timeline

etienneb created this revision.Feb 15 2017, 11:06 AM

Harbormaster completed remote builds in B4008: Diff 88581.Feb 15 2017, 11:06 AM

Herald added subscribers: dberris, kubamracek. · View Herald TranscriptFeb 15 2017, 11:06 AM

Looks good. I guess I forgot to add a test for this API.

This revision is now accepted and ready to land.Feb 15 2017, 11:10 AM

fix linux unittests

Harbormaster completed remote builds in B4012: Diff 88592.Feb 15 2017, 12:26 PM

Looks good

etienneb closed this revision.Feb 15 2017, 12:59 PM

Revision Contents

Path

Size

lib/

asan/

asan_interface.inc

1 line

Diff 88581

lib/asan/asan_interface.inc

	Show First 20 Lines • Show All 139 Lines • ▼ Show 20 Lines
	INTERFACE_FUNCTION(__asan_store16)			INTERFACE_FUNCTION(__asan_store16)
	INTERFACE_FUNCTION(__asan_storeN)			INTERFACE_FUNCTION(__asan_storeN)
	INTERFACE_FUNCTION(__asan_store1_noabort)			INTERFACE_FUNCTION(__asan_store1_noabort)
	INTERFACE_FUNCTION(__asan_store2_noabort)			INTERFACE_FUNCTION(__asan_store2_noabort)
	INTERFACE_FUNCTION(__asan_store4_noabort)			INTERFACE_FUNCTION(__asan_store4_noabort)
	INTERFACE_FUNCTION(__asan_store8_noabort)			INTERFACE_FUNCTION(__asan_store8_noabort)
	INTERFACE_FUNCTION(__asan_store16_noabort)			INTERFACE_FUNCTION(__asan_store16_noabort)
	INTERFACE_FUNCTION(__asan_storeN_noabort)			INTERFACE_FUNCTION(__asan_storeN_noabort)
				INTERFACE_FUNCTION(__asan_unhandled_exception_filter)
	INTERFACE_FUNCTION(__asan_unpoison_intra_object_redzone)			INTERFACE_FUNCTION(__asan_unpoison_intra_object_redzone)
	INTERFACE_FUNCTION(__asan_unpoison_memory_region)			INTERFACE_FUNCTION(__asan_unpoison_memory_region)
	INTERFACE_FUNCTION(__asan_unpoison_stack_memory)			INTERFACE_FUNCTION(__asan_unpoison_stack_memory)
	INTERFACE_FUNCTION(__asan_unregister_globals)			INTERFACE_FUNCTION(__asan_unregister_globals)
	INTERFACE_FUNCTION(__asan_unregister_image_globals)			INTERFACE_FUNCTION(__asan_unregister_image_globals)
	INTERFACE_FUNCTION(__asan_version_mismatch_check_v8)			INTERFACE_FUNCTION(__asan_version_mismatch_check_v8)
	INTERFACE_FUNCTION(__sanitizer_finish_switch_fiber)			INTERFACE_FUNCTION(__sanitizer_finish_switch_fiber)
	INTERFACE_FUNCTION(__sanitizer_print_stack_trace)			INTERFACE_FUNCTION(__sanitizer_print_stack_trace)
	Show All 12 Lines