This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Revert failed scheduling
ClosedPublic

Authored by rampitec on Feb 14 2017, 3:48 PM.

Details

Summary

This patch reverts region's scheduling to the original untouched state
in case if we have have decreased occupancy.

In addition it switches to use TargetRegisterInfo occupancy callback
for pressure limits instead of gradually increasing limits which were
just passed by. We are going to stay with the best schedule so we do
not need to tolerate worsened scheduling anymore.

Using this reversal mechanism we can also try different scheduling
strategies to pick a best one.

Diff Detail

Repository
rL LLVM

Event Timeline

rampitec created this revision.Feb 14 2017, 3:48 PM
vpykhtin edited edge metadata.Feb 15 2017, 7:39 AM

Looks good, but should this be split into 2 changes?

Looks good, but should this be split into 2 changes?

These parts are not extremely independent, as I need to access pressure limits from strategy in the schedule method. I.e. I need them to be unchanged for a region.

vpykhtin accepted this revision.Feb 15 2017, 9:13 AM

LGTM.

This revision is now accepted and ready to land.Feb 15 2017, 9:13 AM
This revision was automatically updated to reflect the committed changes.