This is an archive of the discontinued LLVM Phabricator instance.

Upgrade ios min version to 8
ClosedPublic

Authored by kubamracek on Feb 9 2017, 1:20 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

fjricci created this revision.Feb 9 2017, 1:20 PM
kubamracek edited edge metadata.Feb 10 2017, 2:37 PM

I am in favor of this change (I wanted to raise the deployment target to 8.0 for some time already). @kcc do you still need sanitizers to support deploying to iOS 7?

Actually, if you don't want to be blocked here, you could consider using the same trick as D29786.

Turns out that's a bit tricky, because we need a thread-local AllocatorCache, which is a complex type only defined in the allocator source files.

Turns out that's a bit tricky, because we need a thread-local AllocatorCache, which is a complex type only defined in the allocator source files.

Move it to a header file.

Uploaded a pthreads implementation which makes this patch unnecessary in D29993, D29994, D29995

This revision was automatically updated to reflect the committed changes.

Reverted accidental commit. Abandoning as well, as this is no longer required.

kubamracek reopened this revision.Feb 17 2017, 4:24 PM

Actually, I would still like to push towards making this change. There are other issue with supporting ios/iossim 7.0.

kubamracek commandeered this revision.Feb 17 2017, 4:25 PM
kubamracek edited reviewers, added: fjricci; removed: kubamracek.

I'll commandeer this, hope you don't mind.

@kcc, do you still need ios 7.0 support?

kcc edited edge metadata.Feb 17 2017, 5:12 PM

@kcc, do you still need ios 7.0 support?

Nope.

fjricci accepted this revision.Feb 22 2017, 2:08 PM

Given @kcc's comment, LGTM.

This revision is now accepted and ready to land.Feb 22 2017, 2:08 PM
This revision was automatically updated to reflect the committed changes.