Add lld to test-release.sh
ClosedPublic

Authored by dim on Feb 4 2017, 4:06 AM.

Details

Summary

As Renato suggested, let's add lld to the test-release.sh script.
Building it is enabled by default, but it can be disabled using the
-no-lld option.

We can also disable it by default, like lldb, and add -lld and -no-lld
options instead.

Diff Detail

Repository
rL LLVM
dim created this revision.Feb 4 2017, 4:06 AM

Looks ok. We don't want to use LLD for the bootstrap yet. I'll let Hans approve this one.

cheers,
--renato

Looks good from my side as well. We pushed a similar patch for Polly recently. Let's see what Hans says.
I remember for Polly we started with a disabled flag by default. I wonder if it makes sense to commit this disabled by default. Then ask all release testers to do a test run and switch the flag when these runs where successful?

hans added a comment.Feb 4 2017, 1:56 PM

Adding it makes sense, but I think we should keep it off by default, and then enable it when we start the 5.0 release.

I don't want to add lld to the 4.0 release at this stage.

hans accepted this revision.Feb 4 2017, 2:00 PM

On the other hand, it might be worth a try. Let's add this, and if it causes problems for rc2 we can disable it.

This revision is now accepted and ready to land.Feb 4 2017, 2:00 PM
dim added a comment.Feb 4 2017, 2:16 PM
In D29539#666871, @hans wrote:

On the other hand, it might be worth a try. Let's add this, and if it causes problems for rc2 we can disable it.

Btw do we also merge this to the 4.0 branch? (When I do RC tests, I usually use the test-release.sh script corresponding to the branch under test.)

This revision was automatically updated to reflect the committed changes.
In D29539#666898, @dim wrote:
In D29539#666871, @hans wrote:

On the other hand, it might be worth a try. Let's add this, and if it causes problems for rc2 we can disable it.

Btw do we also merge this to the 4.0 branch? (When I do RC tests, I usually use the test-release.sh script corresponding to the branch under test.)

For historical reasons we must. Or people will have trouble building it in the future.