Add lld to test-release.sh

[dim]

Summary

As Renato suggested, let's add lld to the test-release.sh script.
Building it is enabled by default, but it can be disabled using the
-no-lld option.

We can also disable it by default, like lldb, and add -lld and -no-lld
options instead.

[rengolin]

Looks ok. We don't want to use LLD for the bootstrap yet. I'll let Hans approve this one.

cheers,
--renato

[grosser]

Looks good from my side as well. We pushed a similar patch for Polly recently. Let's see what Hans says.
I remember for Polly we started with a disabled flag by default. I wonder if it makes sense to commit this disabled by default. Then ask all release testers to do a test run and switch the flag when these runs where successful?

[hans]

Adding it makes sense, but I think we should keep it off by default, and then enable it when we start the 5.0 release.

I don't want to add lld to the 4.0 release at this stage.

[hans]

On the other hand, it might be worth a try. Let's add this, and if it causes problems for rc2 we can disable it.

[dim]

In D29539#666871, @hans wrote:

On the other hand, it might be worth a try. Let's add this, and if it causes problems for rc2 we can disable it.

Btw do we also merge this to the 4.0 branch? (When I do RC tests, I usually use the test-release.sh script corresponding to the branch under test.)

[rengolin]

In D29539#666898, @dim wrote:

In D29539#666871, @hans wrote:

On the other hand, it might be worth a try. Let's add this, and if it causes problems for rc2 we can disable it.

Btw do we also merge this to the 4.0 branch? (When I do RC tests, I usually use the test-release.sh script corresponding to the branch under test.)

For historical reasons we must. Or people will have trouble building it in the future.

[dim]

Merged in rL294123.

llvm/trunk/utils/release/test-release.sh

 do_debug="no"
 do_asserts="no"
 do_compare="yes"
 do_rt="yes"
 do_libs="yes"
 do_libunwind="yes"
 do_test_suite="yes"
 do_openmp="yes"
+do_lld="yes"
 do_lldb="no"
 do_polly="no"
 BuildDir="`pwd`"
 ExtraConfigureFlags=""
 ExportBranch=""
 
 function usage() {
     echo "usage: `basename $0` -release X.Y.Z -rc NUM [OPTIONS]"
function usage() {
     echo " -configure-flags FLAGS  Extra flags to pass to the configure step."
     echo " -svn-path DIR        Use the specified DIR instead of a release."
     echo "                      For example -svn-path trunk or -svn-path branches/release_37"
     echo " -no-rt               Disable check-out & build Compiler-RT"
     echo " -no-libs             Disable check-out & build libcxx/libcxxabi/libunwind"
     echo " -no-libunwind        Disable check-out & build libunwind"
     echo " -no-test-suite       Disable check-out & build test-suite"
     echo " -no-openmp           Disable check-out & build libomp"
+    echo " -no-lld              Disable check-out & build lld"
     echo " -lldb                Enable check-out & build lldb"
     echo " -no-lldb             Disable check-out & build lldb (default)"
     echo " -polly               Enable check-out & build Polly"
     echo " -no-polly            Disable check-out & build Polly (default)"
 }
 
 while [ $# -gt 0 ]; do
     case $1 in
case $1 in
             do_libunwind="no"
             ;;
         -no-test-suite )
             do_test_suite="no"
             ;;
         -no-openmp )
             do_openmp="no"
             ;;
+        -no-lld )
+            do_lld="no"
+            ;;
         -lldb )
             do_lldb="yes"
             ;;
         -no-lldb )
             do_lldb="no"
             ;;
         -polly )
             do_polly="yes"

 case $do_test_suite in
   yes|export-only)
     projects="$projects test-suite"
     ;;
 esac
 if [ $do_openmp = "yes" ]; then
   projects="$projects openmp"
 fi
+if [ $do_lld = "yes" ]; then
+  projects="$projects lld"
+fi
 if [ $do_lldb = "yes" ]; then
   projects="$projects lldb"
 fi
 if [ $do_polly = "yes" ]; then
   projects="$projects polly"
 fi
 
 # Go to the build directory (may be different from CWD)
function export_sources() {
     for proj in $projects ; do
         case $proj in
         llvm)
             projsrc=$proj.src
             ;;
         cfe)
             projsrc=llvm.src/tools/clang
             ;;
-        lldb|polly)
+        lld|lldb|polly)
             projsrc=llvm.src/tools/$proj
             ;;
         clang-tools-extra)
             projsrc=llvm.src/tools/clang/tools/extra
             ;;
         compiler-rt|libcxx|libcxxabi|libunwind|openmp)
             projsrc=llvm.src/projects/$proj
             ;;