This is an archive of the discontinued LLVM Phabricator instance.

Merge DebugLoc on combined stores
ClosedPublic

Authored by probinson on Feb 3 2017, 11:51 AM.

Details

Summary

When combining stores at the ends of two blocks, merge the debug location
instead of arbitrarily picking one.

Diff Detail

Event Timeline

probinson created this revision.Feb 3 2017, 11:51 AM
andreadb added inline comments.
test/DebugInfo/Generic/store-tail-merge.ll
5

This test only requires -gline-tables-only. You don't need any @llvm.dbg.value calls and/or extra metadata for debug info types and variables.

69

This entry is not needed. You can get rid of !6. also replace the producer string with an empty string.

aprantl accepted this revision.Feb 6 2017, 9:42 AM

LGTM with outstanding comments addressed.

This revision is now accepted and ready to land.Feb 6 2017, 9:42 AM
probinson marked 2 inline comments as done.Feb 6 2017, 2:27 PM
probinson added inline comments.
test/DebugInfo/Generic/store-tail-merge.ll
5

Oh, good point.

This revision was automatically updated to reflect the committed changes.
probinson marked an inline comment as done.
pmatos added a subscriber: pmatos.Oct 20 2017, 12:42 AM