Page MenuHomePhabricator

[asan] Add __sancov_* symbols to the dynamic symbol table.
ClosedPublic

Authored by mpividori on Jan 30 2017, 11:20 PM.

Details

Summary

I took me some time to understand the reason why "__sancov_*" symbols were not exported.
I wonder why we need an export list? Why cant we just use the visibility for this? We want to have more control on the exported symbols?

Diff Detail

Repository
rL LLVM

Event Timeline

mpividori created this revision.Jan 30 2017, 11:20 PM
mpividori retitled this revision from [asan] Add to [asan] Add __sancov_* symbols to the dynamic symbol table..Jan 30 2017, 11:24 PM
mpividori edited the summary of this revision. (Show Details)
mpividori added reviewers: kcc, zturner, alekseyshl.
mpividori added a subscriber: llvm-commits.

Hi, this change is needed for the test added in: https://reviews.llvm.org/D29148 , when listing the symbols exported with nm -D, __sancov_default_options was not shown before this diff.

@kcc do you agree with this small change?

kcc accepted this revision.Jan 31 2017, 12:09 PM

LGTM

This revision is now accepted and ready to land.Jan 31 2017, 12:09 PM
This revision was automatically updated to reflect the committed changes.