Change debug-info-for-profiling from a TargetOption to a function attribute.

[danielcdh]

Summary

cfe change for https://reviews.llvm.org/D29203

[danielcdh]

change to use module flag.

[mehdi_amini]

lib/CodeGen/CodeGenModule.cpp

452 ↗

(On Diff #86058)

Why should we warn on mismatch?

[danielcdh]

lib/CodeGen/CodeGenModule.cpp

452 ↗

(On Diff #86058)

In theory, we expect this to be the same across all modules. Otherwise when we use this binary for profiling, we may get inaccurate profiles.

[mehdi_amini]

lib/CodeGen/CodeGenModule.cpp

452 ↗

(On Diff #86058)

Oh I thought about the "unset" case but we wouldn't warn in this case.

Indeed we never even should have this flag with a zero value.

[mehdi_amini]

lib/CodeGen/CodeGenModule.cpp

452 ↗

(On Diff #86058)

Unless you really intend to get a warning on mismatch, in which case you should always emit the flag, but with a zero value when not enabled.
I'd need more thought to really grasp all the consequences :)

[danielcdh]

update

[dblaikie]

Oops, forgot to write stuff so the approval appears on-list.

Anyway - looks good/approved.

lib/CodeGen/BackendUtil.cpp

case CodeGenOptions::FPC_Fast:
     Options.AllowFPOpFusion = llvm::FPOpFusion::Fast;
     break;
   }
 
   Options.UseInitArray = CodeGenOpts.UseInitArray;
   Options.DisableIntegratedAS = CodeGenOpts.DisableIntegratedAS;
   Options.CompressDebugSections = CodeGenOpts.CompressDebugSections;
   Options.RelaxELFRelocations = CodeGenOpts.RelaxELFRelocations;
-  Options.DebugInfoForProfiling = CodeGenOpts.DebugInfoForProfiling;
 
   // Set EABI version.
   Options.EABIVersion = llvm::StringSwitch<llvm::EABI>(TargetOpts.EABIVersion)
                             .Case("4", llvm::EABI::EABI4)
                             .Case("5", llvm::EABI::EABI5)
                             .Case("gnu", llvm::EABI::GNU)
                             .Default(llvm::EABI::Default);
 

lib/CodeGen/CodeGenFunction.cpp

void CodeGenFunction::StartFunction(GlobalDecl GD,
   if (const FunctionDecl *FD = dyn_cast_or_null<FunctionDecl>(D))
     if (CGM.getLangOpts().OpenMP && FD->hasAttr<OMPDeclareSimdDeclAttr>())
       CGM.getOpenMPRuntime().emitDeclareSimdFunction(FD, Fn);
 
   // Add no-jump-tables value.
   Fn->addFnAttr("no-jump-tables",
                 llvm::toStringRef(CGM.getCodeGenOpts().NoUseJumpTables));
 
+  // Add debug-info-for-profiling value.
+  Fn->addFnAttr("debug-info-for-profiling",
+                llvm::toStringRef(CGM.getCodeGenOpts().DebugInfoForProfiling));
+
   if (getLangOpts().OpenCL) {
     // Add metadata for a kernel function.
     if (const FunctionDecl *FD = dyn_cast_or_null<FunctionDecl>(D))
       EmitOpenCLKernelMetadata(FD, Fn);
   }
 
   // If we are checking function types, emit a function type signature as
   // prologue data.