[cmake] Remove VERSION property from executable targets

[labath]

Summary

Currently, in the default configuration, the "install" target will
install all llvm executables unversioned, except for three lldb tools
which will be installed versioned (with a non-versioned symlink). This
rectifies that situation.

[labath]

@sylvestre.ledru, I know that debian installs all llvm tools versioned, but I have no idea through which mechanism. I am guessing it must be something different than this, as this is lldb-specific. Do you know if you would be impacted by this?

[mgorny]

Technically the patch looks sane; however, I suggest you wait for some input from the others. As for Gentoo, I don't think we ever really cared for LLDB being versioned — only clang.

[labath]

Thanks. I guess I'll give this one more week, and then commit it if noone objects.

tools/driver/CMakeLists.txt

if ((CMAKE_SYSTEM_NAME MATCHES "Windows") OR
     (CMAKE_SYSTEM_NAME MATCHES "NetBSD" ))
   # These targets do not have getopt support, so they rely on the one provided by
   # liblldb. However, getopt is not a part of the liblldb interface, so we have
   # to link against the constituent libraries manually. Note that this is
   # extremely scary as it introduces ODR violations, and it should go away as
   # soon as possible.
   target_link_libraries(lldb ${LLDB_USED_LIBS})
 endif()
-
-set_target_properties(lldb PROPERTIES VERSION ${LLDB_VERSION})
-

tools/lldb-mi/CMakeLists.txt

 # not re-export those.
 set(LLVM_LINK_COMPONENTS Support)
 add_lldb_tool(lldb-mi ${LLDB_MI_SOURCES})
 
 target_link_libraries(lldb-mi liblldb)
 if (HAVE_LIBPTHREAD)
   target_link_libraries(lldb-mi pthread)
 endif ()
-
-set_target_properties(lldb-mi PROPERTIES VERSION ${LLDB_VERSION})

tools/lldb-server/CMakeLists.txt

if(NOT LLVM_LINK_LLVM_DYLIB)
   # This is necessary in !LLVM_LINK_LLVM_DYLIB as LLDB's libs do not track their
   # dependencies properly. It is conditional because in a LLVM_LINK_LLVM_DYLIB
   # build it would introduce duplicate symbols (add_lldb_tool links to libLLVM,
   # and this would add the individual .a files as well).
   llvm_config(lldb-server ${LLVM_LINK_COMPONENTS})
 endif()
 
 target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
-
-set_target_properties(lldb-server PROPERTIES VERSION ${LLDB_VERSION})