This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Bump up n_type for metadata v2
ClosedPublic

Authored by kzhuravl on Jan 24 2017, 9:29 PM.

Diff Detail

Event Timeline

kzhuravl created this revision.Jan 24 2017, 9:29 PM
arsenm edited edge metadata.Jan 24 2017, 9:54 PM

Needs a test update?

Needs a test update?

No. But we can add a check lines to metadata tests to check for n_type?

Needs a test update?

No. But we can add a check lines to metadata tests to check for n_type?

Needs a test update?

No. But we can add a check lines to metadata tests to check for n_type?

Yes, I think it's surprising there wasn't one before

kzhuravl updated this revision to Diff 85770.Jan 25 2017, 9:44 AM

Add a todo for possibly moving n_type into include/llvm/Support

Needs a test update?

No. But we can add a check lines to metadata tests to check for n_type?

Needs a test update?

No. But we can add a check lines to metadata tests to check for n_type?

Yes, I think it's surprising there wasn't one before

I have added such test in D29131

arsenm accepted this revision.Jan 25 2017, 9:52 AM

LGTM

This revision is now accepted and ready to land.Jan 25 2017, 9:52 AM
This revision was automatically updated to reflect the committed changes.