This is an archive of the discontinued LLVM Phabricator instance.

[lld] [cmake] Fix -rpath-link in stand-alone build
ClosedPublic

Authored by mgorny on Jan 24 2017, 2:44 PM.

Details

Summary

Set LLVM_LIBRARY_OUTPUT_INTDIR as expected by llvm_setup_rpath() macro
when doing stand-alone builds. This is required to pass correct
-rpath-link when linking shared libraries, and therefore ensure that
the linker can find dependency libraries correctly during the build.

Diff Detail

Event Timeline

mgorny created this revision.Jan 24 2017, 2:44 PM

I've filed https://llvm.org/bugs/show_bug.cgi?id=31745 to track it for 4.0.0 backport.

labath edited edge metadata.Jan 25 2017, 12:58 AM

Looks reasonable, but I am somewhat reluctant to hit "approve" on lld changes.

compnerd accepted this revision.Jan 25 2017, 7:31 AM
This revision is now accepted and ready to land.Jan 25 2017, 7:31 AM
This revision was automatically updated to reflect the committed changes.