This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Give up in promote aloca when a pointer may be captured.
ClosedPublic

Authored by cfang on Jan 20 2017, 1:47 PM.

Diff Detail

Event Timeline

cfang created this revision.Jan 20 2017, 1:47 PM
arsenm accepted this revision.Jan 20 2017, 1:59 PM

LGTM with the 2 additional tests

test/CodeGen/AMDGPU/addrspacecast-captured.ll
15–16

No unnamed values

19

Can you add another test which directly stores the addrspacecast, and another which passes the ptrtoint to an external call

This revision is now accepted and ready to land.Jan 20 2017, 1:59 PM

Typo aloca in commit message

cfang updated this revision to Diff 85613.Jan 24 2017, 11:01 AM
cfang edited the summary of this revision. (Show Details)

Add two additional tests.

This revision was automatically updated to reflect the committed changes.