This is an archive of the discontinued LLVM Phabricator instance.

Add indirect call promotion to SamplePGO
ClosedPublic

Authored by danielcdh on Jan 19 2017, 3:34 PM.

Details

Summary

This patch adds metadata for indirect call promotion in the sample profile loader.

Event Timeline

danielcdh created this revision.Jan 19 2017, 3:34 PM
davidxl added inline comments.Jan 20 2017, 10:31 AM
include/llvm/ProfileData/SampleProf.h
241

Add a documentation comment.

lib/Transforms/IPO/SampleProfile.cpp
1106

HeaderLineno --> FuncStartLine?

1119

Can the following be a utility function shared with instrumentation based PGO?

danielcdh updated this revision to Diff 85165.Jan 20 2017, 11:30 AM
danielcdh marked 3 inline comments as done.

Address David's comments.

davidxl accepted this revision.Jan 20 2017, 2:35 PM

lgtm

test/Transforms/SampleProfile/Inputs/indirect-call.prof
3

Swap the targets to test sorting

This revision is now accepted and ready to land.Jan 20 2017, 2:35 PM
danielcdh closed this revision.Jan 20 2017, 3:07 PM
danielcdh marked an inline comment as done.