This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Create objdump subtarget from build attributes
ClosedPublic

Authored by samparker on Jan 16 2017, 3:44 AM.

Details

Summary

My previous commits were reverted in D28683, this patch reapplies them along with the fix from D28678 which has already been accepted. The only original addition that this patch introduces is a check in setARMSubArch to ensure that the CPU_arch attribute exists before trying to read it, as it would seem to be causing the sanitizer failure.

Diff Detail

Event Timeline

samparker updated this revision to Diff 84536.Jan 16 2017, 3:44 AM
samparker retitled this revision from to [ARM] Create objdump subtarget from build attributes.
samparker updated this object.
samparker added a subscriber: llvm-commits.

Hi Sam,

Now that we have a bit more time, would you mind running it through an LLD check?

--renato

Hi Renato,

Yes, I've added LLD to my local build so I know that passes now. But I'm not sure about the issue raised by the sanitizer buildbot, I've fixed the obvious bug on the line reported by the sanitizer and I hope that is all that needs doing.

Cheers,
sam

rengolin accepted this revision.Jan 18 2017, 4:48 AM

Ok, let's try it again.

This revision is now accepted and ready to land.Jan 18 2017, 4:48 AM
This revision was automatically updated to reflect the committed changes.