This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Leak Sanitizer is not supported for Windows.
ClosedPublic

Authored by mpividori on Jan 13 2017, 3:14 PM.

Download Raw Diff

Details

Reviewers

kcc
zturner

Commits

rG5bd35b4d3d44: [libFuzzer] Leak Sanitizer is not supported for Windows.
rL292745: [libFuzzer] Leak Sanitizer is not supported for Windows.

Diff Detail

Event Timeline

mpividori updated this revision to Diff 84397.Jan 13 2017, 3:14 PM

mpividori retitled this revision from to [libFuzzer] Leak Sanitizer is not supported for Windows..

mpividori updated this object.

mpividori added reviewers: kcc, zturner.

mpividori set the repository for this revision to rL LLVM.

mpividori added a subscriber: llvm-commits.

Herald added a subscriber: mgorny. · View Herald TranscriptJan 13 2017, 3:14 PM

This change seems to have some other change (lib->test). is that intended?

@kcc, you are right. That is not intended, I will update the diff. Thanks.

mpividori updated this revision to Diff 84731.Jan 17 2017, 1:08 PM

LGTM

This revision is now accepted and ready to land.Jan 17 2017, 1:12 PM

Closed by commit rL292745: [libFuzzer] Leak Sanitizer is not supported for Windows. (authored by mpividori). · Explain WhyJan 21 2017, 6:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

Fuzzer/

test/

CMakeLists.txt

10 lines

Diff 84397

lib/Fuzzer/test/CMakeLists.txt

Show First 20 Lines • Show All 118 Lines • ▼ Show 20 Lines	set(Tests
Switch2Test		Switch2Test
ThreadedLeakTest		ThreadedLeakTest
ThreadedTest		ThreadedTest
TimeoutTest		TimeoutTest
TimeoutEmptyTest		TimeoutEmptyTest
TraceMallocTest		TraceMallocTest
)		)

if(APPLE)		if(APPLE OR MSVC)
# LeakSanitizer is not supported on OSX right now		# LeakSanitizer is not supported on OSX and Windows right now
set(HAS_LSAN 0)		set(HAS_LSAN 0)
message(WARNING "LeakSanitizer is not supported on Apple platforms."		message(WARNING "LeakSanitizer is not supported."
" Building and running LibFuzzer LeakSanitizer tests is disabled."		" Building and running LibFuzzer LeakSanitizer tests is disabled."
)		)
else()		else()
set(HAS_LSAN 1)		set(HAS_LSAN 1)
endif()		endif()

foreach(Test ${Tests})		foreach(Test ${Tests})
add_libfuzzer_test(${Test} SOURCES ${Test}.cpp)		add_libfuzzer_test(${Test} SOURCES ${Test}.cpp)
▲ Show 20 Lines • Show All 58 Lines • ▼ Show 20 Lines	target_link_libraries(LLVMFuzzer-DSOTest
LLVMFuzzer		LLVMFuzzer
)		)

set_target_properties(LLVMFuzzer-DSOTest PROPERTIES RUNTIME_OUTPUT_DIRECTORY		set_target_properties(LLVMFuzzer-DSOTest PROPERTIES RUNTIME_OUTPUT_DIRECTORY
"${CMAKE_BINARY_DIR}/lib/Fuzzer/test")		"${CMAKE_BINARY_DIR}/lib/Fuzzer/test")

set_output_directory(LLVMFuzzer-DSO1		set_output_directory(LLVMFuzzer-DSO1
BINARY_DIR "${CMAKE_BINARY_DIR}/lib/Fuzzer/test"		BINARY_DIR "${CMAKE_BINARY_DIR}/lib/Fuzzer/test"
LIBRARY_DIR "${CMAKE_BINARY_DIR}/lib/Fuzzer/lib")		LIBRARY_DIR "${CMAKE_BINARY_DIR}/lib/Fuzzer/test")
set_output_directory(LLVMFuzzer-DSO2		set_output_directory(LLVMFuzzer-DSO2
BINARY_DIR "${CMAKE_BINARY_DIR}/lib/Fuzzer/test"		BINARY_DIR "${CMAKE_BINARY_DIR}/lib/Fuzzer/test"
LIBRARY_DIR "${CMAKE_BINARY_DIR}/lib/Fuzzer/lib")		LIBRARY_DIR "${CMAKE_BINARY_DIR}/lib/Fuzzer/test")

set(TestBinaries ${TestBinaries} LLVMFuzzer-DSOTest)		set(TestBinaries ${TestBinaries} LLVMFuzzer-DSOTest)

###############################################################################		###############################################################################
# Configure lit to run the tests		# Configure lit to run the tests
#		#
# Note this is done after declaring all tests so we can inform lit if any tests		# Note this is done after declaring all tests so we can inform lit if any tests
# need to be disabled.		# need to be disabled.
Show All 22 Lines