This is an archive of the discontinued LLVM Phabricator instance.

CodeGen: Add another method to MachineInstrBuilder. NFC
ClosedPublic

Authored by rovka on Jan 11 2017, 4:29 AM.

Details

Summary

Add a method that allows adding multiple operands simultaneously to a
MachineInstrBuilder. This is especially useful for operands that are closely
related, such as those representing the predicate on ARM instructions (one
immediate + one register operand).

Diff Detail

Event Timeline

rovka updated this revision to Diff 83956.Jan 11 2017, 4:29 AM
rovka retitled this revision from to CodeGen: Add another method to MachineInstrBuilder. NFC.
rovka updated this object.
rovka added reviewers: MatzeB, kristof.beyls.
rovka added subscribers: llvm-commits, rengolin.
MatzeB accepted this revision.Jan 11 2017, 9:22 AM
MatzeB edited edge metadata.

LGTM

include/llvm/CodeGen/MachineInstrBuilder.h
195

The const is unnecessary for immutable classes like ArrayRef or StringRef (though it doesn't hurt either).

196

MachineOperand instead of auto would be friendlier for readers.

This revision is now accepted and ready to land.Jan 11 2017, 9:22 AM
rovka added a comment.Jan 13 2017, 1:51 AM

Squashed with D28555. Thanks for reviewing!

rovka closed this revision.Jan 13 2017, 2:00 AM