Page MenuHomePhabricator

Check for musl-libc's max_align_t in addition to other variants.
ClosedPublic

Authored by dlj on Jan 9 2017, 1:19 PM.

Details

Summary

Libcxx will define its own max_align_t when it is not available. However, the
availability checks today only check for Clang's definition and GCC's
definition. In particular, it does not check for musl's definition, which is the
same as GCC's but guarded with a different macro.

Diff Detail

Repository
rL LLVM

Event Timeline

dlj updated this revision to Diff 83681.Jan 9 2017, 1:19 PM
dlj retitled this revision from to Check for musl-libc's max_align_t in addition to other variants..
dlj updated this object.
dlj added a reviewer: mclow.lists.
dlj added a subscriber: cfe-commits.
chandlerc added a subscriber: chandlerc.

This seems good to me. Check with Eric to see if we try to test this any any specific way?

EricWF accepted this revision.Feb 9 2017, 5:29 PM

LGTM.

This revision is now accepted and ready to land.Feb 9 2017, 5:29 PM
EricWF added a comment.Feb 9 2017, 5:32 PM

IDK how to meaningly test this though.

dlj added a comment.Feb 9 2017, 5:36 PM

IDK how to meaningly test this though.

Heh. Well... I can tell you that with this change (and a couple of others), I'm able to bootstrap Clang (2-stage) using libc++ on Alpine Linux. It totally works, I promise! ;-)

This revision was automatically updated to reflect the committed changes.