This is an archive of the discontinued LLVM Phabricator instance.

Differential D28439

[libFuzzer] Specify the CRT considered (MT or MD) to the linker.
ClosedPublic

Authored by mpividori on Jan 6 2017, 9:18 PM.

Details

Reviewers
kcc
zturner
Commits
rG76c58b44137c: [libFuzzer] Specify the CRT considered (MT or MD) for tests on Windows.
rL292749: [libFuzzer] Specify the CRT considered (MT or MD) for tests on Windows.

Diff Detail

Event Timeline

mpividori updated this revision to Diff 83505.Jan 6 2017, 9:18 PM
mpividori retitled this revision from to [libFuzzer] Always use MD for tests..
mpividori updated this object.
mpividori added a reviewer: zturner.
mpividori set the repository for this revision to rL LLVM.
mpividori added a subscriber: llvm-commits.
Herald added a subscriber: mgorny. · View Herald TranscriptJan 6 2017, 9:18 PM
kcc accepted this revision.Jan 10 2017, 3:52 PM
kcc added a reviewer: kcc.
kcc added a subscriber: kcc.

LGTM

This revision is now accepted and ready to land.Jan 10 2017, 3:52 PM
mpividori updated this revision to Diff 84176.Jan 12 2017, 2:04 PM
mpividori retitled this revision from [libFuzzer] Always use MD for tests. to [libFuzzer] Specify the CRT considered (MT or MD) to the linker..
mpividori edited edge metadata.
mpividori removed rL LLVM as the repository for this revision.
mpividori requested a review of this revision.Jan 13 2017, 9:20 PM
mpividori edited edge metadata.

Would you agree with this last changes?

zturner accepted this revision.Jan 17 2017, 10:09 AM
This revision is now accepted and ready to land.Jan 17 2017, 10:09 AM
Closed by commit rL292749: [libFuzzer] Specify the CRT considered (MT or MD) for tests on Windows. (authored by mpividori). · Explain WhyJan 21 2017, 6:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Fuzzer/
test/
3 lines

Diff 83505

lib/Fuzzer/test/CMakeLists.txt

Show All 22 Linesforeach (VARNAME ${variables_to_filter})
endforeach() endforeach()
set(${VARNAME} "${new_flags}") set(${VARNAME} "${new_flags}")
endforeach() endforeach()
# Enable the coverage instrumentation (it is disabled for the Fuzzer lib). # Enable the coverage instrumentation (it is disabled for the Fuzzer lib).
set(CMAKE_CXX_FLAGS "${LIBFUZZER_FLAGS_BASE} -fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp,trace-div,trace-gep -gline-tables-only") set(CMAKE_CXX_FLAGS "${LIBFUZZER_FLAGS_BASE} -fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp,trace-div,trace-gep -gline-tables-only")
if(MSVC) if(MSVC)
# Always use MD, since sanitizer coverage is currently not supported for MT.
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /MD")
# In order to use the sanitizers in Windows, we need to link against many # In order to use the sanitizers in Windows, we need to link against many
# runtime libraries which will depend on the target being created # runtime libraries which will depend on the target being created
# (executable or dll) and the c runtime library used (MT/MD). # (executable or dll) and the c runtime library used (MT/MD).
# By default, cmake uses link.exe for linking, which fails because we don't # By default, cmake uses link.exe for linking, which fails because we don't
# specify the appropiate dependencies. # specify the appropiate dependencies.
# As we don't want to consider all of that possible situations which depends # As we don't want to consider all of that possible situations which depends
# on the implementation of the compiler-rt, the simplest option is to change # on the implementation of the compiler-rt, the simplest option is to change
# the rules for linking executables and shared libraries, using the compiler # the rules for linking executables and shared libraries, using the compiler
▲ Show 20 Lines • Show All 203 Lines • Show Last 20 Lines