This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Specify the CRT considered (MT or MD) to the linker.
ClosedPublic

Authored by mpividori on Jan 6 2017, 9:18 PM.

Download Raw Diff

Details

Reviewers

kcc
zturner

Commits

rG76c58b44137c: [libFuzzer] Specify the CRT considered (MT or MD) for tests on Windows.
rL292749: [libFuzzer] Specify the CRT considered (MT or MD) for tests on Windows.

Diff Detail

Repository: rL LLVM

Event Timeline

mpividori updated this revision to Diff 83505.Jan 6 2017, 9:18 PM

mpividori retitled this revision from to [libFuzzer] Always use MD for tests..

mpividori updated this object.

mpividori added a reviewer: zturner.

mpividori set the repository for this revision to rL LLVM.

mpividori added a subscriber: llvm-commits.

Herald added a subscriber: mgorny. · View Herald TranscriptJan 6 2017, 9:18 PM

LGTM

This revision is now accepted and ready to land.Jan 10 2017, 3:52 PM

mpividori updated this revision to Diff 84176.Jan 12 2017, 2:04 PM

mpividori retitled this revision from [libFuzzer] Always use MD for tests. to [libFuzzer] Specify the CRT considered (MT or MD) to the linker..

mpividori edited edge metadata.

mpividori removed rL LLVM as the repository for this revision.

Would you agree with this last changes?

zturner accepted this revision.Jan 17 2017, 10:09 AM

This revision is now accepted and ready to land.Jan 17 2017, 10:09 AM

Closed by commit rL292749: [libFuzzer] Specify the CRT considered (MT or MD) for tests on Windows. (authored by mpividori). · Explain WhyJan 21 2017, 6:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

lib/

Fuzzer/

test/

CMakeLists.txt

11 lines

Diff 85270

llvm/trunk/lib/Fuzzer/test/CMakeLists.txt

	Show All 12 Lines
	foreach (VARNAME ${variables_to_filter})			foreach (VARNAME ${variables_to_filter})
	string(REGEX REPLACE "([-/]O)[123s]" "\\10" ${VARNAME} "${${VARNAME}}")			string(REGEX REPLACE "([-/]O)[123s]" "\\10" ${VARNAME} "${${VARNAME}}")
	endforeach()			endforeach()

	# Enable the coverage instrumentation (it is disabled for the Fuzzer lib).			# Enable the coverage instrumentation (it is disabled for the Fuzzer lib).
	set(CMAKE_CXX_FLAGS "${LIBFUZZER_FLAGS_BASE} -fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp,trace-div,trace-gep -gline-tables-only")			set(CMAKE_CXX_FLAGS "${LIBFUZZER_FLAGS_BASE} -fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp,trace-div,trace-gep -gline-tables-only")

	if(MSVC)			if(MSVC)
				# For tests use the CRT specified for release build
				# (asan doesn't support MDd and MTd)
				if ("${LLVM_USE_CRT_RELEASE}" STREQUAL "")
				set(CRT_FLAG " /MD ")
				else()
				set(CRT_FLAG " /${LLVM_USE_CRT_RELEASE} ")
				endif()
	# In order to use the sanitizers in Windows, we need to link against many			# In order to use the sanitizers in Windows, we need to link against many
	# runtime libraries which will depend on the target being created			# runtime libraries which will depend on the target being created
	# (executable or dll) and the c runtime library used (MT/MD).			# (executable or dll) and the c runtime library used (MT/MD).
	# By default, cmake uses link.exe for linking, which fails because we don't			# By default, cmake uses link.exe for linking, which fails because we don't
	# specify the appropiate dependencies.			# specify the appropiate dependencies.
	# As we don't want to consider all of that possible situations which depends			# As we don't want to consider all of that possible situations which depends
	# on the implementation of the compiler-rt, the simplest option is to change			# on the implementation of the compiler-rt, the simplest option is to change
	# the rules for linking executables and shared libraries, using the compiler			# the rules for linking executables and shared libraries, using the compiler
	# instead of link.exe. Clang will consider the sanitizer flags, and			# instead of link.exe. Clang will consider the sanitizer flags, and
	# automatically provide the required libraries to the linker.			# automatically provide the required libraries to the linker.
	set(CMAKE_CXX_LINK_EXECUTABLE "<CMAKE_CXX_COMPILER> <FLAGS> ${CMAKE_CXX_FLAGS} <OBJECTS> -o <TARGET> <LINK_LIBRARIES> /link <CMAKE_CXX_LINK_FLAGS> <LINK_FLAGS>")			set(CMAKE_CXX_LINK_EXECUTABLE "<CMAKE_CXX_COMPILER> <FLAGS> ${CMAKE_CXX_FLAGS} ${CRT_FLAG} <OBJECTS> -o <TARGET> <LINK_LIBRARIES> /link <CMAKE_CXX_LINK_FLAGS> <LINK_FLAGS>")
	set(CMAKE_CXX_CREATE_SHARED_LIBRARY "<CMAKE_CXX_COMPILER> ${CMAKE_CXX_FLAGS} /LD <CMAKE_SHARED_LIBRARY_CXX_FLAGS> <CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS> <CMAKE_SHARED_LIBRARY_SONAME_CXX_FLAG> <TARGET_SONAME> -o <TARGET> <OBJECTS> <LINK_LIBRARIES> /link <LINK_FLAGS>")			set(CMAKE_CXX_CREATE_SHARED_LIBRARY "<CMAKE_CXX_COMPILER> ${CMAKE_CXX_FLAGS} ${CRT_FLAG} /LD <CMAKE_SHARED_LIBRARY_CXX_FLAGS> <CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS> <CMAKE_SHARED_LIBRARY_SONAME_CXX_FLAG> <TARGET_SONAME> -o <TARGET> <OBJECTS> <LINK_LIBRARIES> /link <LINK_FLAGS>")
	endif()			endif()

	# add_libfuzzer_test(<name>			# add_libfuzzer_test(<name>
	# SOURCES source0.cpp [source1.cpp ...]			# SOURCES source0.cpp [source1.cpp ...]
	# )			# )
	#			#
	# Declares a LibFuzzer test executable with target name LLVMFuzzer-<name>.			# Declares a LibFuzzer test executable with target name LLVMFuzzer-<name>.
	#			#
	▲ Show 20 Lines • Show All 200 Lines • Show Last 20 Lines